Deal rooms and co-invest: join checks the deal, a Free investor can still leave, and co-invest is Institutional as the pricing page says (D614)

[guillaumelauzier]

S1: Four gate fixes on deal rooms and co-invest. Decision D614. No migration. Found by #1165's audit (area 6).

What is true on main

• Join. POST /api/deals/:id/dealroom/join (cloudflare-worker/src/routes/deals.ts) inserts a membership without checking that the deal exists, so a bad id still uses up a quota slot.
• Leave. Every /api/deals/* route sits behind requireInvestorTier('professional') (cloudflare-worker/src/index.ts, INVESTOR_PRO_PREFIXES). An investor who drops to Free cannot call DELETE /api/deals/:id/dealroom/leave for the rooms they joined.
• Co-invest. GET /api/funds/syndication (routes/funds.ts) checks only the role. The pricing page (frontend/src/pages/InvestorPricingPage.jsx) sells "Co-invest discovery" as Institutional only, yet any investor reads every listing.
• Create. POST /api/deals takes any status. A status the table's CHECK does not allow becomes a 500.

The work

1. Join answers 404 deal_not_found for a deal that does not exist, and writes nothing.
2. Leave is reachable on any plan: exempt that one route from the Professional gate. The rest of /api/deals/* stays gated.
3. Co-invest requires Institutional for investors. Use the same middleware and paywall shape (required: 'institutional'), so the client's paywall opens. Admins and partners pass, as today.
4. Create refuses an unknown status with a 400 that lists the allowed ones, read from the same list the table allows.
5. D614 records the four gates.

Files this task owns

• cloudflare-worker/src/routes/deals.ts (join and create only)
• cloudflare-worker/src/index.ts (the investor gate's mounts only)
• cloudflare-worker/src/routes/funds.ts (the syndication route only)
• new Worker tests
• documentation/architecture/decisions/D614.md

Done when

• Tests cover:
  • join refused for an unknown deal, using no quota;
  • a Free investor can leave a room but still cannot list deals;
  • co-invest answers 402 with required: 'institutional' for a Professional investor, and 200 for an Institutional investor, an admin and a partner;
  • create refuses a bad status with a 400.
• Every new assertion is mutation-checked.

---

Generated by Claude Code

[guillaumelauzier]

STATUS
task: #1307   slot: S07   agent: Claude Code
branch: agent/claude-b/1307-dealroom-gates
state: IN_PROGRESS
files: routes/deals.ts (join, create), index.ts (investor gate mounts), routes/funds.ts (syndication), new Worker tests, decisions/D614.md
blockers: none
questions: none yet
tests: not run yet
pr: none yet

---

Generated by Claude Code

[guillaumelauzier]

STATUS
task: #1307   slot: S07   agent: Claude Code
branch: agent/claude-b/1307-dealroom-gates
state: READY_FOR_REVIEW
files: routes/deals.ts (join, create), index.ts (gate mounts), middleware/requireInvestorTier.ts (INVESTOR_PRO_EXEMPT, requireInvestorTierExcept), routes/funds.ts (syndication), dealroom_coinvest_gates_d614.test.ts, lp_money_authz_d370.test.ts, decisions/D614.md
blockers: none
questions: none
tests: build exit 0; test:drift EXIT=0; 5 new tests; 13 mutations, all caught
pr: https://github.com/AxalNetwork/StudioOS/pull/1325 (draft, Closes #1307)

Two notes:

• The leave exemption lives in middleware/requireInvestorTier.ts, beside the gate it wraps, so the test can mount it as index.ts does. That file isn't on the owned list.
• POST /api/deals still accepts rejected. The table allows it, and this issue only refuses unknown statuses. D614 records this as left open.

---

Generated by Claude Code

[guillaumelauzier]

STATUS
task: #1307   slot: S07   agent: Claude Code
branch: agent/claude-b/1307-dealroom-gates
state: DONE
files: routes/deals.ts, index.ts, middleware/requireInvestorTier.ts, routes/funds.ts, dealroom_coinvest_gates_d614.test.ts, lp_money_authz_d370.test.ts, decisions/D614.md
blockers: none
questions: one is still open: whether POST /api/deals should refuse 'rejected' and send it through POST /:id/pass, as /draft and PUT do. D614 records it.
tests: test:drift EXIT=0; CI green on the merged head
pr: #1325 (merged)

---

Generated by Claude Code