Repository navigation
D607: the Ops canvas graduates, and /account's sections are one menu on a phone (part of #1165) - #1318
Merged
Conversation
…on a phone (#1165) The owner's newer export of Ops Page changes one thing: on a phone the Account center's section list is one "Section ▾" row instead of a row of chips that scrolled sideways. AccountSectionNav now draws that row below lg, over a transparent native select ("Account section"), so a phone opens its own picker. From lg the column is unchanged. Ops · Boards, Ops Page and ops-data.js move from design/incoming to design/canvases/integrated: all five areas run on main (D567 to D571). integrated/ goes 77 -> 79 in both READMEs; the intake README's row for the four later areas names their routes and decisions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018jkNYLq29UXAvcqYxGCSB3
|
Preview: https://studioos-pr-1318.guillaumelauzier.workers.dev (built from 938136c) The pull request's SPA build on a Worker with no bindings: pages and deep links work, |
guillaumelauzier
marked this pull request as ready for review
October 6, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Your new Ops export, applied. You sent five links on #1165. They are one canvas, the Ops canvas from D566: four carry the same newer
Ops Page, and the fifth is the export before it. The newer export changes one thing: on a phone, the Account center's sections become a single "Section ▾" row instead of a row of chips that scrolls sideways. This PR:/account;main.Part of #1165, which stays open for areas 6 to 8; their design prompts are posted there.
Implementation
The phone section menu (
pages/account/AccountCenter.jsx)lgup, nothing changes. The section list is the column beside the content, with "More" over the four kept sections.lg, it is one row. The row reads "Section", then the open section's name, then ▾. It is 44px tall and drawn as a card with a hairline border, as the canvas draws.op-secdrop.The canvas files
The moves.
Ops · Boards.dc.html,Ops Page.dc.htmlandops-data.jsmove fromdesign/incoming/todesign/canvases/integrated/. All five areas are built: D567 to D571.The newer export replaces
Ops Page. Its diff against the committed file is the design's change and nothing else:op-secdroprow;acCurrent;The export's three serialisation differences were kept in the committed form.
The counts.
integrated/goes from 77 to 79 in both READMEs.The intake README's row for the four later areas now names their routes and decisions; it read "not yet triaged".
ROUTE_MAP's Account row records D568 and D607.
Where the build departs from the canvas, and why
role="listbox"list that answered Escape but no arrow keys. A native select needs no focus code, and on a phone it is the picker people already know.Files changed
frontend/src/pages/account/AccountCenter.jsx(AccountSectionNav)frontend/test/account_center_d568.test.mjsdesign/canvases/integrated/Ops Page.dc.html,Ops · Boards.dc.htmlandops-data.js(moved;Ops Pagereplaced)design/canvases/README.mddesign/incoming/README.mddocumentation/architecture/decisions/D607.md(new)documentation/architecture/ROUTE_MAP.md(the Account row)Testing
The full suite.
npm run build, thennpm run test:drift, gaveEXIT=0on this PR's head (938136c10, onmainat892392af6):lint:undefand the dark-mode check all pass.The D568 test checks:
lgshape;lgup, and is 44px tall;onSelect;A rendered check. The built bundle was served with stubbed
/apireplies at 390, 820 and 1280 wide, in light and dark:/account/following);Risks
lgsee one Section row on/accountinstead of a row of chips.Dependencies
None. D604 (#1303) merged first; this is rebased onto it.
Agent
S01 · Claude Code
Review requested
The owner.
🤖 Generated with Claude Code
https://claude.ai/code/session_018jkNYLq29UXAvcqYxGCSB3
Generated by Claude Code