Repository navigation
Conversation
Ensure CommandChannelImpl registered handler count logs only once. Do so by validating on the existing log line if resubscribing is happening. Additionally, add another log block on registerCommandHandler when registering for the first time #463
Ensure QueryChannelImpl registered handler count logs only once. Do so by validating on the existing log line if resubscribing is happening. Additionally, add another log block on registerQueryHandler when registering for the first time #463
m1l4n54v1c
reviewed
Aug 24, 2026
m1l4n54v1c
approved these changes
Aug 24, 2026
m1l4n54v1c
left a comment
m1l4n54v1c
left a comment
Contributor
There was a problem hiding this comment.
One small concern about double logigng.
Deduplicate specific handler registration duplication #463
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the logging behavior of the
CommandChannelImplandQueryChannelImplto ensure we only log successfully if handlers are actually registered.This is done by checking if we're registering handlers for the first time or registering as part of a reconnect.
By doing the above, this PR resolve #463.