feat(github): color-code inline diffs on the pull request page - #359
Open
abdulwahabmonilola-ctrl wants to merge 1 commit into
Open
abdulwahabmonilola-ctrl wants to merge 1 commit into
abdulwahabmonilola-ctrl wants to merge 1 commit into
Conversation
abdulwahabmonilola-ctrl
force-pushed
the
feat/71-color-coded-inline-diff
branch
from
October 4, 2026 08:17
5c88cc0 to
9be7a2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
What
The pull request detail page rendered each file patch as a monochrome escaped
<pre>, while the commit page already usedGitHub.renderPatch.Changes
app/static/js/github_pull.js- route each file's patch throughGH.renderPatch(file.patch), which classifies added (+) lines, removed (-) lines, hunk headers (@@), file metadata, and context lines, and HTML-escapes every line.Acceptance criteria
+render in the added style (green via.diff-added).-render in the removed style (red via.diff-removed)..diff-lineonly).renderPatchonly classifies the patch it is given).Validation
pytest tests/test_github_diff_highlighting.py-> 5 passed (evaluatesrenderPatchunder Node with a DOM shim, plus wiring/CSS checks).ruff checkandblack --checkclean on the changed test file.