Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4851319
kicad pane + hub: a KiCad left by a thread switch is out of the pane …
Nov 20, 2026
481ef48
kicad pane: a leave from another thread than the pane's last says thr…
Nov 20, 2026
1d0d8df
e2e embed_leave_idle: the header says what each row checks and what m…
Nov 20, 2026
1f13020
#1470 review: a default-idle unit test (no BACKPLANE_KICAD_IDLE_S: us…
Nov 20, 2026
dfc13c3
kicad pane: a frame closed while the pane is off screen is the idle c…
Nov 20, 2026
88d92a2
kicad embed: an attach never reuses a KiCad that is closing; the pane…
Nov 20, 2026
1dba659
kicad pane: only the person's own Edit waits on a closing KiCad and s…
Nov 20, 2026
aac019b
kicad embed: a KiCad still running 15 s after the hub's own idle or e…
Nov 20, 2026
c8247e1
kicad embed: an idle or eviction Close KiCad refuses ends the closing…
Nov 20, 2026
357735a
From the cross-model review of 6a053a3c50, as the KiCad lead confirmed:
Nov 20, 2026
eb891da
#1470 delta review (Fable): a leave or a detach while a start waits o…
Nov 20, 2026
69b99de
#1470: a start that waits on the project's previous KiCad is held as …
Nov 20, 2026
abf3ef5
#1470 adversarial review: a leave or back is ordered by the pane's ow…
Nov 20, 2026
1c9df0a
#1470 interaction review (Fable), the KiCad lead's rule: a pane off t…
Nov 21, 2026
8808820
#1470: the dialog-closed focus, the click-took-it refocus and Windows…
Nov 21, 2026
1b5f476
Keep KiCad keyboard hand-ins on the page and retry after layout
Nov 21, 2026
481be3e
i18n: regenerate Android and iOS catalogs for gpui.c.kicad.closing (#…
Nov 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions i18n/en.msg
Original file line number Diff line number Diff line change
Expand Up @@ -2202,6 +2202,7 @@ gpui.c.kicad.missing.edit = KiCad isn't installed. Press Edit to install it here
gpui.c.kicad.full.screen = Full screen
gpui.c.kicad.exit.full.screen = Exit full screen
gpui.c.kicad.the.editor.takes.the.whole = The editor takes the whole window; only this row stays
gpui.c.kicad.closing = KiCad is closing. The editor opens again once it has closed.

# ---- gpui-d: setup, pairing, hubs, palette, picker, projects, composer, menus ----
gpui.assets.missing = Assets missing in {dir}: {files}
Expand Down
1 change: 1 addition & 0 deletions i18n/es.msg
Original file line number Diff line number Diff line change
Expand Up @@ -2203,6 +2203,7 @@ gpui.c.kicad.missing.edit = KiCad no está instalado. Pulsa Editar para instalar
gpui.c.kicad.full.screen = Pantalla completa
gpui.c.kicad.exit.full.screen = Salir de pantalla completa
gpui.c.kicad.the.editor.takes.the.whole = El editor ocupa toda la ventana; solo queda esta fila
gpui.c.kicad.closing = KiCad se está cerrando. El editor vuelve a abrirse cuando termine de cerrarse.

# ---- gpui-d: setup, pairing, hubs, palette, picker, projects, composer, menus ----
gpui.assets.missing = Faltan recursos en {dir}: {files}
Expand Down
1 change: 1 addition & 0 deletions i18n/ja.msg
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,7 @@ gpui.c.kicad.missing.edit = KiCad がインストールされていません。
gpui.c.kicad.full.screen = 全画面
gpui.c.kicad.exit.full.screen = 全画面を終了
gpui.c.kicad.the.editor.takes.the.whole = エディタがウィンドウ全体を使います。この行だけが残ります
gpui.c.kicad.closing = KiCad を閉じています。閉じ終わるとエディタがもう一度開きます。

# ---- gpui-d: setup, pairing, hubs, palette, picker, projects, composer, menus ----
gpui.assets.missing = {dir} にアセットがありません: {files}
Expand Down
5,398 changes: 2,702 additions & 2,696 deletions mobile/android/app/src/main/java/dev/backplane/mobile/Msg.kt

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions mobile/ios/Shared/TrCatalog.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2577,6 +2577,7 @@ gpui.c.kicad.missing.edit KiCad isn't installed. Press Edit to install it here.
gpui.c.kicad.full.screen Full screen 全画面 Pantalla completa
gpui.c.kicad.exit.full.screen Exit full screen 全画面を終了 Salir de pantalla completa
gpui.c.kicad.the.editor.takes.the.whole The editor takes the whole window; only this row stays エディタがウィンドウ全体を使います。この行だけが残ります El editor ocupa toda la ventana; solo queda esta fila
gpui.c.kicad.closing KiCad is closing. The editor opens again once it has closed. KiCad を閉じています。閉じ終わるとエディタがもう一度開きます。 KiCad se está cerrando. El editor vuelve a abrirse cuando termine de cerrarse.
gpui.assets.missing Assets missing in {dir}: {files} {dir} にアセットがありません: {files} Faltan recursos en {dir}: {files}
gpui.connecting Connecting… 接続中… Conectando…
gpui.connected Connected 接続済み Conectado
Expand Down
10 changes: 8 additions & 2 deletions native/gpui/src/ui.rs
Original file line number Diff line number Diff line change
Expand Up @@ -865,8 +865,14 @@ impl Render for Backplane {
// whether the page holds the embedded editor this frame (popped out: its own window does), from this frame's state: macOS hides
// KiCad's frame by it when the pane is not drawn (#1199: the viewer closed, the PCB Editor stayed on screen)
if let Some(p) = self.screens.kicad.clone() {
let in_page = self.screens.kicad_window.is_some() || (!docked && self.kicad_for(thread, cx).is_some() && crate::screens::viewer::holds_editor(thread));
if p.read(cx).in_page != in_page { p.update(cx, |p, _| p.in_page = in_page); }
let mine = self.kicad_for(thread, cx).is_some();
let in_page = self.screens.kicad_window.is_some() || (!docked && mine && crate::screens::viewer::holds_editor(thread));
// #1345: off screen because the person moved away (another thread or design, or the viewer closed or on another page): the hub
// hears it once settled (KicadPane::set_in_page), so the idle close and the cap can apply to it; a sheet over the pane is not this
// ("thread": another thread than the one the pane was last on screen in, the same project's included; "viewer": the same thread)
let tid = thread["id"].as_str().unwrap_or("");
if p.read(cx).in_page != in_page { p.update(cx, |p, cx| p.set_in_page(in_page, if mine && p.page_thread == tid { "viewer" } else { "thread" }, cx)); } // i18n-ok: wire words
if in_page && p.read(cx).page_thread != tid { let t = tid.to_string(); p.update(cx, |p, _| p.page_thread = t); }
}
// Follow agent in KiCad: the hub learns whether this thread's page holds KiCad and which frame it shows (viewer.state, on change)
let kshown = match self.screens.kicad.clone() { Some(p) if p.read(cx).in_page => (true, p.read(cx).tab()), _ => (false, String::new()) };
Expand Down
Loading
Loading