Repository navigation
mac-build.sh: copy every file outside native/gpui the client's build reads, derived from its sources - #1475
Merged
Conversation
…reads, derived from its sources A fresh MAC_DEST on the mini failed three times in a row (Nov 20, #1470's check): build.rs reads native/winres.rs, and the client's #[path] modules read native/host/src/{mouse,scopeprobe,bots/cat}.rs; none was copied. scripts/gpui-outside-files.py lists, from the sources each time, every #[path] module and literal include_str!/include_bytes!/include! in native/gpui/src and build.rs that lies outside native/gpui, followed into the .rs files it names (comments ignored; a named file that is missing is an error), and mac-build.sh copies that list (rsync --files-from) beside the native/gpui copy. Nothing else in the script changes. Checked: --self-test (a made-up tree); on hs-mac-mini, a fresh MAC_DEST (~/bp-macsync) `mac-build.sh check` exits 0 (cargo check --release --features cef), the folder deleted after (0.93 GB; 12 GB free before and after). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
force-pushed
the
fix/mac-build-outside-files
branch
from
November 21, 2026 02:51
a187a4c to
0a2273e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh MAC_DEST on the mini failed three times in a row (Nov 20, #1470's check): build.rs reads native/winres.rs, and the client's
#[path] modules read native/host/src/{mouse,scopeprobe,bots/cat}.rs; none was copied. scripts/gpui-outside-files.py lists, from the
sources each time, every #[path] module and literal include_str!/include_bytes!/include! in native/gpui/src and build.rs that lies
outside native/gpui, followed into the .rs files it names (comments ignored; a named file that is missing is an error), and
mac-build.sh copies that list (rsync --files-from) beside the native/gpui copy. Nothing else in the script changes.
Checked: --self-test (a made-up tree); on hs-mac-mini, a fresh MAC_DEST (~/bp-macsync)
mac-build.sh checkexits 0 (cargo check--release --features cef), the folder deleted after (0.93 GB; 12 GB free before and after).
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
🤖 Generated with Claude Code