Skip to content

mac-build.sh: copy every file outside native/gpui the client's build reads, derived from its sources - #1475

Merged
i2cjak merged 1 commit into
mainfrom
fix/mac-build-outside-files
Nov 21, 2026
Merged

i2cjak merged 1 commit into
mainfrom
fix/mac-build-outside-files

Conversation

@i2cjak

@i2cjak i2cjak commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

A fresh MAC_DEST on the mini failed three times in a row (Nov 20, #1470's check): build.rs reads native/winres.rs, and the client's
#[path] modules read native/host/src/{mouse,scopeprobe,bots/cat}.rs; none was copied. scripts/gpui-outside-files.py lists, from the
sources each time, every #[path] module and literal include_str!/include_bytes!/include! in native/gpui/src and build.rs that lies
outside native/gpui, followed into the .rs files it names (comments ignored; a named file that is missing is an error), and
mac-build.sh copies that list (rsync --files-from) beside the native/gpui copy. Nothing else in the script changes.

Checked: --self-test (a made-up tree); on hs-mac-mini, a fresh MAC_DEST (~/bp-macsync) mac-build.sh check exits 0 (cargo check
--release --features cef), the folder deleted after (0.93 GB; 12 GB free before and after).

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

🤖 Generated with Claude Code

…reads, derived from its sources

A fresh MAC_DEST on the mini failed three times in a row (Nov 20, #1470's check): build.rs reads native/winres.rs, and the client's
#[path] modules read native/host/src/{mouse,scopeprobe,bots/cat}.rs; none was copied. scripts/gpui-outside-files.py lists, from the
sources each time, every #[path] module and literal include_str!/include_bytes!/include! in native/gpui/src and build.rs that lies
outside native/gpui, followed into the .rs files it names (comments ignored; a named file that is missing is an error), and
mac-build.sh copies that list (rsync --files-from) beside the native/gpui copy. Nothing else in the script changes.

Checked: --self-test (a made-up tree); on hs-mac-mini, a fresh MAC_DEST (~/bp-macsync) `mac-build.sh check` exits 0 (cargo check
--release --features cef), the folder deleted after (0.93 GB; 12 GB free before and after).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@i2cjak
i2cjak force-pushed the fix/mac-build-outside-files branch from a187a4c to 0a2273e Compare November 21, 2026 02:51
@i2cjak
i2cjak merged commit 3aa2e42 into main Nov 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant