Repository navigation
Linux: a KiCad pane off the page takes no input or focus (the focus proxy only where its frame is on screen; no presses off page) - #1556
Merged
Conversation
i2cjak
force-pushed
the
fix/pane-press-off-page
branch
from
November 21, 2026 05:55
fcdf30c to
38d2888
Compare
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…e map; the key taken back in detach(); the came move counted against the redirect cap; pane-side tests (#1556 review 2, 3, 4) The tick reported the frame on screen up to 40 ms after it was mapped: a key typed in between, the pointer resting where the pane appeared, went to KiCad. A pane whose container another takes over (take_kept) could remove that pane's entry from its own late tick or Drop: detach() now takes its key back and forgets it. pane_shows and screen_rekey are pure and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
force-pushed
the
fix/pane-press-off-page
branch
from
November 21, 2026 06:12
38d2888 to
43cb72e
Compare
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…before the old container goes (the old window no longer redirects with no frame in it until the next tick); pane_shows and screen_rekey moved above mac_shown's doc comment; note_pane_on_screen's doc names every caller Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…e map; the key taken back in detach(); the came move counted against the redirect cap; pane-side tests (#1556 review 2, 3, 4) The tick reported the frame on screen up to 40 ms after it was mapped: a key typed in between, the pointer resting where the pane appeared, went to KiCad. A pane whose container another takes over (take_kept) could remove that pane's entry from its own late tick or Drop: detach() now takes its key back and forgets it. pane_shows and screen_rekey are pure and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
force-pushed
the
fix/pane-press-off-page
branch
from
November 21, 2026 06:18
5c3d9a4 to
6b66f90
Compare
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…before the old container goes (the old window no longer redirects with no frame in it until the next tick); pane_shows and screen_rekey moved above mac_shown's doc comment; note_pane_on_screen's doc names every caller Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…e map; the key taken back in detach(); the came move counted against the redirect cap; pane-side tests (#1556 review 2, 3, 4) The tick reported the frame on screen up to 40 ms after it was mapped: a key typed in between, the pointer resting where the pane appeared, went to KiCad. A pane whose container another takes over (take_kept) could remove that pane's entry from its own late tick or Drop: detach() now takes its key back and forgets it. pane_shows and screen_rekey are pure and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
force-pushed
the
fix/pane-press-off-page
branch
from
November 21, 2026 06:28
6b66f90 to
37a17a3
Compare
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…before the old container goes (the old window no longer redirects with no frame in it until the next tick); pane_shows and screen_rekey moved above mac_shown's doc comment; note_pane_on_screen's doc names every caller Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…her viewer on show) The hidden pane's frame rectangle is where that viewer's page now is: a click in the Browser tab's page was taken for a press in the editor, and its release handed the keyboard to the hidden KiCad frame (kicad_focus at the release, traced), taking it from the page the person clicked. in_page (false when the thread's viewer holds no editor) gates it; the press state is cleared while out of the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… is on screen (per top-level, per child); the Browser e2e's page JSON-quoted, its B3 reading the page's own log With another viewer on show (the Browser tab) a pane's frame is unmapped: nothing of KiCad is under the pointer, so the redirect stays off and the focus is where GPUI and the Browser put it, as before #1505. The Browser's own click hand-back (its want_yank) put the focus on the top-level and the redirect then moved it to the proxy: a click into a Browser page with a KiCad pane in the window gave the page no keys. PaneScreens (top-level -> children on screen) is tested; the pane reports (top-level, container) each tick and takes it back when either changes or it is dropped; coming on screen moves a focus left on the top-level to the proxy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e map; the key taken back in detach(); the came move counted against the redirect cap; pane-side tests (#1556 review 2, 3, 4) The tick reported the frame on screen up to 40 ms after it was mapped: a key typed in between, the pointer resting where the pane appeared, went to KiCad. A pane whose container another takes over (take_kept) could remove that pane's entry from its own late tick or Drop: detach() now takes its key back and forgets it. pane_shows and screen_rekey are pure and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…before the old container goes (the old window no longer redirects with no frame in it until the next tick); pane_shows and screen_rekey moved above mac_shown's doc comment; note_pane_on_screen's doc names every caller Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
i2cjak
force-pushed
the
fix/pane-press-off-page
branch
from
November 21, 2026 07:02
37a17a3 to
a379190
Compare
i2cjak
pushed a commit
that referenced
this pull request
Nov 21, 2026
…e map; the key taken back in detach(); the came move counted against the redirect cap; pane-side tests (#1556 review 2, 3, 4) The tick reported the frame on screen up to 40 ms after it was mapped: a key typed in between, the pointer resting where the pane appeared, went to KiCad. A pane whose container another takes over (take_kept) could remove that pane's entry from its own late tick or Drop: detach() now takes its key back and forgets it. pane_shows and screen_rekey are pure and tested. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Linux regression found by the Browser-tab row of #1505: with a KiCad pane in the window (but not on screen), a click into a Browser page gave the page no keys. Per the KiCad lead: a pane that is off the page must not take input or focus.
1. The focus proxy applies only while a KiCad pane's frame is on screen in that window (
viewers/native_child.rs, Linux).CefPage::render→want_yank→give_keyboard(false)→focus_host(top), traced) put the focus on the top-level, and the redirect then moved it to the proxy.PaneScreens: top-level → the children on screen in it. It's keyed per child, so the Browser lane can register a shown page too, and it's unit-tested.(top-level, container)as on screen whenin_pageand its last placement showed a frame. It takes the entry back when either changes, and when it's dropped.home_of, pump()'s FocusIn redirect,note_pane_keys' transition and re-check, and the proxy's first move all apply only where a pane is on screen. Coming on screen with the focus on the top-level itself (and Backplane holding the keys) moves it to the proxy again.2. No press handling while the pane is not in the page (
viewers/kicad_pane.rs). The hidden pane handled presses by its frame's old rectangle, where the Browser page now is, and on release handed the keyboard to the hidden KiCad frame (traced).3. The Browser e2e (
test/kicad_embed/embed_pointer_keys_browser_e2e.sh):Measured (desktop Xvfb + i3, a cef client from this branch):
embed_pointer_keys_e2e.sh: case b 13/13 and case a 13/13, the race 20/20 in both.cargo test: 917 passed.windows-check gpuiis clean.Split view (a KiCad pane and the Browser both on screen in one window): the pane's frame is on screen, so the redirect is on. A click into the Browser page is then yanked by the Browser's own code and moved to the proxy, as on main today. That case is the Browser lane's: its fix (the person's click from XI2 raw presses, the page registered in
PaneScreens) must cover it.🤖 Generated with Claude Code