Repository navigation
kicad: no KiCad at Edit offers the install above the pane (after the person's Edit; their press is the consent); free-space check before the download; support re-read after the install - #1560
Closed
i2cjak wants to merge 1 commit into
Conversation
…(after the person's Edit only; Install KiCad is the consent, Set a path… opens Settings → CAD); the pane drops its dead Try again and Open the KiCad app; an install is refused for space before anything downloads (archive left + 5x unpacked + a tenth); support re-read before the install says done Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a new person hits: with no KiCad, Edit used to end in "KiCad could not start: KiCad was not found: set its path in Settings > CAD" with Try again and Open the KiCad app instead. Both did nothing: there is no KiCad to retry or open. Setup's auto-install runs only in setup, once.
The design was agreed with the KiCad lead and the right-rail lead.
Client
screens/kicad_update.rs, the existing row above the pane (never over it), gets two new states:Missing: "KiCad isn't installed. Backplane KiCad {version} ({size}) goes into {folder}, with no administrator password." Buttons Install KiCad (kicad-update:install) and Set a path… (kicad-update:path, which opens Settings → CAD's existing page).NoPackage: none is published for this computer. The hub's reason, and Set a path…ShowBy::Deliberate. It never shows on open, an agent's show, an automatic attach, a pre-warm or a restored tile layout.viewers/kicad_pane.rs:no_kicad(info)covers a failed start whose reason is "KiCad was not found". There, Try again and Open the KiCad app are not offered.kicad.install {consent: true}. The hub'srefusalstill refuses without consent.reattach_why/turned_since, unchanged).scripts/i18n-gate.shis clean).Hub
kicad/install.rs:missing_offeris published inkicad.updateas{missing, to, size, mb, folder, admin}, or{missing, nopackage, words}, when the CAD status is "missing". It carries noofferfield, because it is not an update.folder_words:~/…on Linux and macOS, and the full%LOCALAPPDATA%\Backplane\kicadpath on Windows. This replaces the old folder text in the consent line.needs_adminis false on every platform, becausemanaged_parentis the person's own folder, so "with no administrator password" holds everywhere. The text has a variant without it, should that change.need_bytesis the rest of the archive, plusUNPACK_X(5) × the archive for the unpacked runtime, plus a tenth.UNPACK_Xis measured from the bp.13.3 packages: macOS 4.11× on disk (APFS, Lane M), Linux 4.66×, Windows 4.73× (its zip's file sizes). The largest, rounded up, is used for every platform. No pin format change.space_refusal: "Not enough free space for KiCad: it needs about {need} in {folder}, and {free} is free". Free space that can't be read lets the install proceed, and so does a placeholder pin with size 0.free_bytesreads statvfs (Unix) or GetDiskFreeSpaceExW (Windows) on the nearest existing folder.embed::refresh_supportruns beforekicad.installsays done. Before this, the pane kept the missing runtime's support.kicad/ipc.rs:publish_cadpublishesupdate_offer, or failing that,missing_offer.Tests
kicad::install37/0,kicad::ipc19/0:an_install_is_refused_for_space_before_anything_downloads: the rule, partials, unknowns, and the three measured packages underUNPACK_X.free_space_is_read_where_the_install_goes_or_above_itthe_offer_names_the_folder_as_the_person_reads_itno_kicad_at_all_is_offered_the_install_and_one_with_no_package_says_why: also checks that consent is still required.a_missing_kicad_is_offered_only_after_the_persons_edit_and_only_their_press_installs: no row and no install on a pane that isn't the person's; the words; the admin variant; no package; running; space; offline; failed.a_pane_with_no_kicad_offers_no_dead_controlscripts/windows-check.sh hostandgpuipass.cfg(target_os = "macos")code. The free-space read is the genericcfg(unix)branch and the folder text is chosen at run time, so the Linux and Windows compiles cover it.Release QA: the fresh-home Edit → Install row per platform, including Carbon's refused-Edit → Install row, and
measure_no_kicadturned into a row.Review brief: find a way an install starts without the person's press, and a way the pane is left on a dead control.
🤖 Generated with Claude Code