Repository navigation
fix/browser keys proxy - #1566
Merged
Merged
Conversation
…I2 raw press inside the page's container, taken once within 400 ms), also when CEF reports only on_got_focus Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… too (one focus watcher thread for every native child; the Browser gives the keyboard back to the proxy); sequence e2e S1-S3 and focus_trace gap A window with only the Browser left Backplane's keyboard on the top-level itself, and core X gave every key typed with the pointer over the page to Chromium (B2/B4). The page now registers as a native child (native_child adopt_child / note_pane_on_screen with its container), its focus_host goes to the proxy (focus_home), and the FocusIn redirect runs on a thread and connection of its own (x11-focus-proxy) for every top-level with a proxy, not on the pane's wake thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser keyboard focus on Linux
Keep the composer keyboard on GPUI's proxy while a Browser page or KiCad pane is visible. Record the X11 button press on the page before replaying it to Chromium, so a real click retains the keyboard when CEF reports focus asynchronously. The Browser returns focus only while its own container still holds it. The X server serializes focus ownership checks and updates.
The watcher retries redirects when the cap's rest ends, with a logged pane fallback if the watcher dies. KiCad dialog recovery respects focus already in Backplane.
Review and verification