Skip to content

fix: update LLM reasoning configuration in ocr_review workflow - #46

Merged
BasuruK merged 6 commits into
masterfrom
feature/basuruk/setting-ocr-review-fix
Sep 27, 2026
Merged

BasuruK merged 6 commits into
masterfrom
feature/basuruk/setting-ocr-review-fix

Conversation

@BasuruK

@BasuruK BasuruK commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

User description

  • Changed the LLM reasoning effort parameter to "medium" and reset the llm_extra_body to an empty JSON object in the ocr_review.yml workflow.
  • This update aims to refine the LLM configuration for improved performance and clarity in the workflow settings.

PR Type

Bug fix


Description

  • Replace llm_extra_body with llm_reasoning_effort input parameter

  • Source effort from OCR_LLM_REASONING_EFFORT variable

  • Fall back to high when the variable is unset


File Walkthrough

Relevant files
Configuration changes
ocr_review.yml
Switch to variable-based LLM reasoning effort                       

.github/workflows/ocr_review.yml

  • Removed llm_extra_body: '{"reasoning":{"enabled":true}}' input passed
    to the OCR action
  • Added llm_reasoning_effort: ${{ vars.OCR_LLM_REASONING_EFFORT ||
    'high' }} input
  • Switched from inline JSON reasoning config to a dedicated,
    variable-driven parameter
+1/-1     

- Changed the LLM reasoning effort parameter to "medium" and reset the `llm_extra_body` to an empty JSON object in the `ocr_review.yml` workflow.
- This update aims to refine the LLM configuration for improved performance and clarity in the workflow settings.
@BasuruK BasuruK self-assigned this Sep 27, 2026
@BasuruK BasuruK added the bug Something isn't working label Sep 27, 2026
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9f81932b-49b8-48b2-af4e-2ba9d009bb5e

📥 Commits

Reviewing files that changed from the base of the PR and between 861afc8 and 0824cc1.

📒 Files selected for processing (1)
  • .github/workflows/ocr_review.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 437cdffa-70ee-4ac2-8cd7-3b39b63b29b3

📥 Commits

Reviewing files that changed from the base of the PR and between e6ac946 and 861afc8.

📒 Files selected for processing (1)
  • .github/workflows/ocr_review.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: code-review
🔇 Additional comments (1)
.github/workflows/ocr_review.yml (1)

121-122: 🗄️ Data Integrity & Integration

The action supports llm_reasoning_effort: medium and maps it to reasoning_effort for the selected OpenAI-compatible protocol. The configured OCR_LLM_URL and OCR_LLM_MODEL values are not present in the repository, so their support for that field cannot be determined. The comment identifies an unresolved compatibility check, not a demonstrated failure.


Summary by CodeRabbit

  • Chores
    • Automated code reviews now use a medium reasoning effort setting, with additional reasoning options left unset. This updates the configuration used to generate review feedback. No changes to product features or user-facing behavior are included.

Walkthrough

The OpenCodeReview action now sets reasoning effort to medium and passes an empty llm_extra_body.

Changes

OCR review settings

Layer / File(s) Summary
Update action reasoning parameters
.github/workflows/ocr_review.yml
The workflow sets llm_reasoning_effort to medium and replaces the reasoning-enabled extra body with an empty value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 861af

No established issue blocks merging this workflow change. Compatibility with the configured model has not been confirmed.

Architecture Summary

Architecture risk: 🔵 Low · up to 861af

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/ocr_review.yml: The action now explicitly sets reasoning effort to medium and supplies an empty extra body instead of sending {"reasoning":{"enabled":true}}.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the update to the LLM reasoning configuration in the OCR review workflow.
Description check ✅ Passed The description accurately summarizes the changes to llm_reasoning_effort and llm_extra_body in the workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow file,
Then hops along with settings mild.
“Medium,” it says, and twitches ears,
An empty body now appears.
It nibbles clover, pleased to see,
The changed request go cleanly free.

Comment @coderabbitai help to get the list of available commands.

@joe-abey

joe-abey Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 0824cc1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@opencodereview-ocr-bot

opencodereview-ocr-bot Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🔍 OpenCodeReview found 2 issue(s) in this PR.

  • ✅ Successfully posted inline: 2 comment(s)

Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
Co-authored-by: opencodereview-ocr-bot[bot] <333014842+opencodereview-ocr-bot[bot]@users.noreply.github.com>
@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit 8771519

Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
- Updated the LLM reasoning effort parameter from "medium" to "max" in the `ocr_review.yml` workflow.
- This change aims to enhance the performance of the LLM by allowing for maximum reasoning effort during processing.
- Deleted the `llm_extra_body` parameter from the `ocr_review.yml` workflow as it was set to an empty JSON object, which is no longer necessary.
- This change aims to streamline the workflow configuration by eliminating redundant settings.
@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit ae78331

@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit a942127

@angry-karen

angry-karen Bot commented Sep 27, 2026

Copy link
Copy Markdown

kody code-review Kody Rules high

Dead configuration: llm_extra_body: "{}" is an empty JSON object that is never read or varied, serving only as a speculative, unused placeholder. Remove this line.

Kody rule violation: Ponytail Audit

Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
- Replaced the hardcoded value of the `llm_reasoning_effort` parameter with a variable reference `${{ vars.OCR_LLM_REASONING_EFFORT }}` in the `ocr_review.yml` workflow.
- This change enhances configurability by allowing the reasoning effort to be dynamically set through workflow variables.
@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit 989ce3b

Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
Comment thread .github/workflows/ocr_review.yml Outdated
Co-authored-by: opencodereview-ocr-bot[bot] <333014842+opencodereview-ocr-bot[bot]@users.noreply.github.com>
@joe-abey

joe-abey Bot commented Sep 27, 2026

Copy link
Copy Markdown

Persistent review updated to latest commit 0824cc1

Comment thread .github/workflows/ocr_review.yml
Comment thread .github/workflows/ocr_review.yml
@BasuruK
BasuruK merged commit 5d9a564 into master Sep 27, 2026
3 checks passed
@BasuruK
BasuruK deleted the feature/basuruk/setting-ocr-review-fix branch September 27, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Review effort 1/5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant