Skip to content

Add Node.js version 26.7.0 with configuration and launch scripts - #43

Open
N6REJ wants to merge 2 commits into
mainfrom
26.7.0
Open

Add Node.js version 26.7.0 with configuration and launch scripts#43
N6REJ wants to merge 2 commits into
mainfrom
26.7.0

Conversation

@N6REJ

@N6REJ N6REJ commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@N6REJ
N6REJ requested a review from jwaisner August 26, 2026 12:17
@N6REJ N6REJ added the enhancement ✨ Improve program label Aug 26, 2026
Auto-generated from release 2026.8.26
@qodo-code-review

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Package Node.js 26.7.0 for Bearsampp

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Adds Bearsampp packaging and launch support for Node.js 26.7.0.
• Configures portable npm cache, prefix, and global settings for the new runtime.
• Removes stale configuration artifacts from superseded Node.js package directories.
Diagram

graph TD
  A["Build metadata"] --> B["Node 26.7"] --> C["Bearsampp config"] --> D["Launch script"] --> E["npm runtime config"]
  C --> F["npm defaults"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Generate version configuration during Gradle packaging
  • ➕ Eliminates repeated embedded version paths
  • ➕ Reduces copy-forward mistakes between Node.js releases
  • ➕ Centralizes the package template
  • ➖ Requires build-system changes beyond this release
  • ➖ Makes generated package contents less visible in source control
  • ➖ Needs validation across existing release workflows

Recommendation: Keep the version-directory approach for Node.js 26.7.0 because it matches the established Bearsampp packaging contract and limits release risk. Consider generating these files from a Gradle template separately, since the repeated version strings and stale-artifact cleanup indicate preventable maintenance overhead.

Files changed (5) +10 / -2

Enhancement (1) +0 / -0
launch.batInitialize portable npm settings at launch +0/-0

Initialize portable npm settings at launch

• Derives the package directory, writes npm's local prefix, loads Node.js environment variables, and sets the package npmrc as the global configuration.

bin/nodejs26.7.0/launch.bat

Other (4) +10 / -2
bearsampp.confDeclare Node.js 26.7.0 package metadata +1/-1

Declare Node.js 26.7.0 package metadata

• Corrects the package version from the copied 25.3.0 value to 26.7.0 while retaining the standard Bearsampp executable, npm, launcher, and configuration declarations.

bin/nodejs26.7.0/bearsampp.conf

npmrcAdd portable npm defaults for Node.js 26.7.0 +4/-0

Add portable npm defaults for Node.js 26.7.0

• Configures the shared npm cache and version-specific global, initialization, and user configuration paths for the 26.7.0 package.

bin/nodejs26.7.0/etc/npmrc

npmrc.berAdd npm configuration template for path rewriting +4/-0

Add npm configuration template for path rewriting

• Adds the Bearsampp template counterpart of the npm defaults, preserving portable path placeholders for packaging and restoration workflows.

bin/nodejs26.7.0/etc/npmrc.ber

build.propertiesAdvance the Node.js bundle release date +1/-1

Advance the Node.js bundle release date

• Updates the bundle release identifier from 2026.7.11 to 2026.8.26 for the new packaged runtime.

build.properties

@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Historical versions become unbuildable 🐞 Bug ≡ Correctness
Description
Deleting the 26.3.0 bundle metadata removes that version—and likewise 22.22.1, 24.14.x, and 25.x
versions deleted in this PR—from both bin/ and bin/archived/, so `gradle release
-PbundleVersion=26.3.0` now rejects a version that remains in the release registry. The build
explicitly supports historical bundles through bin/archived/, so these directories must be moved
there rather than removed.
Code

bin/nodejs26.3.0/bearsampp.conf[1]

-nodejsVersion = "26.3.0"
Evidence
The release task validates that a requested version directory exists in either the active or
archived tree and throws otherwise. The PR branch has neither location for 26.3.0, while the
checked-in registry still advertises 26.3.0 as a released version; the documented archive layout
exists specifically for historical bundle overlays.

build.gradle[441-446]
releases.properties[1-4]
.gradle-docs/README.md[191-191]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR deletes bundle overlays for previously released Node.js versions, making those versions unavailable to the Gradle release task even though historical bundles are supported and still registered.

## Issue Context
Preserve each removed version by moving its complete configuration overlay under `bin/archived/nodejs<version>/` rather than deleting it. Avoid duplicating versions that already have a complete archived overlay.

## Fix Focus Areas
- bin/nodejs22.22.1/bearsampp.conf[1-8]
- bin/nodejs24.14.0/bearsampp.conf[1-8]
- bin/nodejs24.14.1/bearsampp.conf[1-8]
- bin/nodejs25.2.1/bearsampp.conf[1-8]
- bin/nodejs25.3.0/etc/npmrc[1-4]
- bin/nodejs25.8.0/bearsampp.conf[1-8]
- bin/nodejs25.9.0/bearsampp.conf[1-8]
- bin/nodejs26.3.0/bearsampp.conf[1-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
Review mode: ⚖️ Balanced: This adds runtime Node.js configuration and launch assets while deleting and regenerating related versioned configs; the broad multi-file change has meaningful behavioral and packaging risk, but is largely repetitive rather than defect-dense enough for extended review.

Grey Divider

Tip of the day
💡 Did you know, you can start a comment with 'qodo' or '@qodo' to chat about any finding

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@@ -1,8 +0,0 @@
nodejsVersion = "26.3.0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Historical versions become unbuildable 🐞 Bug ≡ Correctness

Deleting the 26.3.0 bundle metadata removes that version—and likewise 22.22.1, 24.14.x, and 25.x
versions deleted in this PR—from both bin/ and bin/archived/, so `gradle release
-PbundleVersion=26.3.0` now rejects a version that remains in the release registry. The build
explicitly supports historical bundles through bin/archived/, so these directories must be moved
there rather than removed.
Agent Prompt
## Issue description
The PR deletes bundle overlays for previously released Node.js versions, making those versions unavailable to the Gradle release task even though historical bundles are supported and still registered.

## Issue Context
Preserve each removed version by moving its complete configuration overlay under `bin/archived/nodejs<version>/` rather than deleting it. Avoid duplicating versions that already have a complete archived overlay.

## Fix Focus Areas
- bin/nodejs22.22.1/bearsampp.conf[1-8]
- bin/nodejs24.14.0/bearsampp.conf[1-8]
- bin/nodejs24.14.1/bearsampp.conf[1-8]
- bin/nodejs25.2.1/bearsampp.conf[1-8]
- bin/nodejs25.3.0/etc/npmrc[1-4]
- bin/nodejs25.8.0/bearsampp.conf[1-8]
- bin/nodejs25.9.0/bearsampp.conf[1-8]
- bin/nodejs26.3.0/bearsampp.conf[1-8]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants