Repository navigation
Conversation
…ingdotgg#22617) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ads (pingdotgg#34638) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#22795) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ercent-encoded (pingdotgg#36929) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#15622) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#35135) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ses for them (pingdotgg#36950) Co-authored-by: 0xpolarzero <0xpolarzero@gmail.com>
…ingdotgg#23166) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#22614) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#30066) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…9466) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#23134) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…t switches back (pingdotgg#30107) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…g#24140) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#34636) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#30209) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#31640) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…efusing it (pingdotgg#31661) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#31695) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ranch on its t3/ name (pingdotgg#31662) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#31738) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Federico Lomurno <275704276+flomurno@users.noreply.github.com>
…other limits (pingdotgg#31748) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… every folder for each expansion (pingdotgg#31465) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#31781) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…nd draft rows (pingdotgg#31195) Co-authored-by: Julius Marminge <julius0216@outlook.com>
pingdotgg#31593) Co-authored-by: Matyas Rathonyi <matyasrathonyi@imac-server2.tailacc4a3.ts.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#31752) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…text (pingdotgg#31780) Co-authored-by: Julius Marminge <julius0216@outlook.com>
|
This PR changes the test suite by +134 test cases (browser +10, unit +66, server +58). New browser test files: Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the desktop app, a page in a Browser tab that calls
alert()orconfirm()opens Electron's native app-modal box over the whole window. It appears even when you are in another thread and does not say which tab it came from.When the agent answers with
preview_dialog, the page gets the answer, but the native box stays until the tab closes. The last comment on pingdotgg#17518 reports the same thing. pingdotgg#32847 fixes the hang when answering, and leaves the native box alone.Repro: open a page in the Browser panel and run
confirm("Delete this draft?").Change
-run-dialoghandler is replaced. The dialog stays pending on its tab asdialogin the tab state. It is answered over IPC (answerDialog) or by CDPPage.handleJavaScriptDialog. It clears onPage.javascriptDialogClosed, a main-frame navigation, a closed or replaced guest, or a destroyed guest, the same way Chrome dismisses dialogs on navigation.ServerBrowserSurfaceintoBrowserDialogCard, and its copy does not change.Scope
prompt()is not supported in Electron renderers, so it never reaches this path.beforeunload, and the mini player.preview_status.-run-dialogand-cancel-dialogsare internal Electron events. The Electron version is pinned. If they are renamed, dialogs fall back to the native box, and nothing hangs.Verification
PageDialogs.test.tsand new cases inManager.test.tscover these, and they fail onmain:Page.javascriptDialogOpeningfires, and both a CDP answer and a card answer reach the page.did-start-navigationfires while the dialog blocks, but the commit waits for the answer.alert(),confirm()and a delayedalert():trueandfalse.Page.navigatewith a pending dialog all load with no stale card.alert()on page load shows the card.alert()shows the card when the panel reopens.vp run check:changedpasses, except for the browser tests. They need Playwright Chromium, which is not installed locally.Model: Claude Opus 5.5 and Claude Sonnet 5.5. Harness: Claude Code in T3 Code.