Share the metadata map-copy helper between Players and Island - #3085
Merged
Merged
Conversation
SonarCloud flagged the toConcurrentMap helper and getMetaData body added in #3082 as a duplicated block across Players and Island. Move the helper to a static method on MetaDataAble so there is one copy, and have both implementations call it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarCloud flagged a duplicated block on the 3.23.0 release PR (#3084): the
toConcurrentMaphelper andgetMetaDatabody added in #3082 were identical inPlayersandIsland.This moves the helper to a static method on
MetaDataAble, which both classes implement, and has both call it. No behaviour change.PlayersTest,IslandTest,UserTest: all pass.🤖 Generated with Claude Code