Build with JDK 25 in CI - #460
Merged
Merged
Conversation
BentoBox 3.23 and later are compiled for Java 25 (class version 69), so JDK 21 cannot compile against them. Use JDK 25 in the build and Modrinth publish workflows so the addon can move to a current BentoBox. The bytecode target stays at Java 21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ItemsAdder's old repo (maven.devs.beer) returns 522, which broke dependency resolution in CI. The API is now published to Maven Central as beer.devs:itemsadder-api, matching BentoBox. Drop the old repo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BentoBox 3.23 and later are compiled for Java 25, so CI on JDK 21 fails with
class file has wrong version 69.0, should be 65.0when compiling against them. This happened in Limits (BentoBoxWorld/Limits#305).This PR changes
java-versionfrom 21 to 25 inbuild.ymlandmodrinth-publish.yml. The pom'sjava.version(the bytecode target) stays at 21, as in Limits and OneBlock. JaCoCo 0.8.14 already supports Java 25.Level is still on BentoBox 3.15.1-SNAPSHOT, so this gets CI ready for the bump.
mvn clean packagepasses locally on JDK 25 (256 tests).🤖 Generated with Claude Code