Repository navigation
Update to Sylius 2.3 - #299
Merged
Merged
Conversation
tests/Application/composer.lockPackage changes
Settings · Docs · Powered by Private Packagist |
Wojdylak
approved these changes
Oct 16, 2026
- Support Sylius ^2.2, Symfony ^6.4 || ^7.4 || ^8.0, PHP ^8.3, Elasticsearch 8/9 - Drop minimum-stability dev; pin ruflin/elastica, conflict slevomat >=8.23 (ECS 12 bundles phpcs 3) - Replace tests/Application with sylius/test-application (tests/TestApplication) - Rework CI around SyliusLabs/BuildTestAppAction, fold coding standard job into build - Use explicit imports in PHP service configs - Fix max price validation message, implicit nullable params, Request::get() usage and specs broken on master - Add UPGRADE-6.0.0.md, update docs, bump branch alias to 6.0-dev
|
The composer.lock diff comment has been updated to reflect new changes in this PR. |
Wojdylak
approved these changes
Oct 16, 2026
- Bind enabled flag as boolean in ProductAttributeValueRepository instead of comparing with 1 - Index and query taxon codes as stored instead of lowercasing them, fixing taxon facet labels on case-sensitive databases and attribute filters for mixed-case taxon codes - Look up taxon by code in ancestor taxon repository test instead of relying on row order
The plugin's taxon route shares its path with "sylius_shop_product_index", so whichever was imported first handled the request. With sylius/test-application (plugin routes imported last) the plain Sylius listing without facets was shown. Also redefine "sylius_shop_product_index" to point to the plugin's controller, so the plugin's listing is used regardless of the import order, and cover taxon page facets in Behat.
Real applications import the plugin's routes before Sylius' shop routes, so the plugin's taxon listing already wins there. Only sylius/test-application imports plugin routes last, so override "sylius_shop_product_index" there instead of in the plugin's routing. Fix the file name in the routing import example in the installation docs.
Wojdylak
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.