Repository navigation
Refresh facet indexes on product save with application model classes - #302
Open
Darkorzerarko wants to merge 1 commit into
Open
Darkorzerarko wants to merge 1 commit into
Darkorzerarko wants to merge 1 commit into
Conversation
ResourceIndexListener compared the configured attribute and option models with Sylius' base classes by name. In applications that map them to their own classes (the Sylius Standard default), saving a product or variant never refreshed bitbag_attribute_taxons and bitbag_option_taxons. Check the models against ProductAttributeInterface and ProductOptionInterface instead. Fixes BitBagCommerce#301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301, likely also the cause of #232.
ResourceIndexListenercompared the configured attribute and option models with Sylius' base classes by name, so inapplications with their own model classes (the Sylius Standard default) saving a product or variant never refreshed
bitbag_attribute_taxonsandbitbag_option_taxons. The models are now checked by interface:Added
ResourceIndexListenerSpec; the application-model examples fail without the fix. PHPStan passes, and phpspec has no new failures (the 6 broken examples are broken onmastertoo).