Repository navigation
Add Sylius 1.14 support - #23
Merged
Merged
Conversation
liszkapawel
force-pushed
the
feature/sylius-1.14-ing-pay-rebranding
branch
from
October 5, 2026 06:41
790f5de to
94720cd
Compare
liszkapawel
changed the title
- sylius/sylius ~1.13.0 || ~1.14.0 and php ^8.1, dropping Sylius 1.12 and PHP 8.0 - CI matrix updated accordingly - branch-alias points at the 1.x branch instead of a master branch that does not exist - allow installing api-platform/core and enshrined/svg-sanitize, which Sylius 1.x pins and Composer 2.9+ blocks over security advisories - pin squizlabs/php_codesniffer to the 3.x line, as 4.0 is not compatible with the slevomat sniffs the resolver pairs it with - fix NotifyActionSpec constructor arguments and 6 PHPStan errors in NotifyAction, both already failing on v1.0.3 The plugin's namespaces, service ids, routes, gateway factory name and configuration fields are unchanged, so no application or database change is required.
liszkapawel
force-pushed
the
feature/sylius-1.14-ing-pay-rebranding
branch
from
October 5, 2026 07:05
94720cd to
bf04e77
Compare
symfony server:ca:install installs the CA into the system trust store and then exits 1 because no browser NSS database exists at that point, which failed every job in the matrix. The step only mattered for Behat over the HTTPS base url, and this workflow runs no Behat step, nor does the plugin define any suites.
The test application ships no yarn.lock, so yarn resolves the newest sass, which requires node >=20.19.0 and fails every node 18 job. Node 18 reached end of life in April 2025.
senghe
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Sylius 1.14 to the 1.x line, which stopped at
~1.13.0. The 2.x and 3.x releases are aSylius 2.0 rewrite, so there is no upgrade path for shops that are on 1.x.
Nothing is renamed: namespaces, service ids, routes, the
imojegateway factory name and thegateway configuration fields are untouched, so this is a drop-in upgrade with no data migration.
Changes
php ^8.1andsylius/sylius ~1.13.0 || ~1.14.0. Sylius 1.12 and PHP 8.0 support are dropped,matching how the other BitBag plugins moved onto the 1.14 line. The symfony dev dependencies move
from
^6.0to^6.4, which is what Sylius 1.14 requires.~1.13.0/~1.14.0, followingSyliusShippingExportPlugin v3.2.0.RegisterGatewayConfigTypePassis identicalacross 1.12, 1.13 and 1.14, the
sylius.gateway_configuration_typetag is unchanged,payum/payum-bundlestays at^2.5, and everyPayum\Core\*class the plugin uses is stillprovided after 1.13 replaced the
payum/payummetapackage withpayum/offline.Fixes to the existing pipeline
Both were already failing on
v1.0.3, verified by running them against that tag:NotifyActionSpecconstructedNotifyActionwith 2 of its 5 arguments, breaking 5 of 43examples.
NotifyActiondereferenced five nullable values unguarded in thepayment.status === 'error'branch, producing 6 PHPStan errors.
Composer 2.9+ also refuses to install
api-platform/coreandenshrined/svg-sanitize, both pinnedby Sylius 1.x with no advisory-free release in range, and the resolver pairs
squizlabs/php_codesniffer4.0 with incompatible slevomat sniffs on some matrix legs. Both areunrelated to this change, but no dependency resolution succeeds without them.
Verification
Tested on PHP 8.1 and MySQL 8 on the plugin test application against Sylius 1.13.17 and 1.14.20,
and on a clean
sylius/sylius-standard1.14.6 with the plugin installed via Composer.In each one: the container builds, the gateway registers as
imoje, a payment method is createdthrough the admin UI, all five configuration fields render and round-trip, Payum builds the gateway
from the stored config, and
POST /payment/imoje/notifyis routed.