Skip to content

fix(abstract-utxo): pass Zcash recovery block height - #9683

Draft
ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
fix/sc-7552-zec-recovery-height
Draft

fix(abstract-utxo): pass Zcash recovery block height#9683
ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
fix/sc-7552-zec-recovery-height

Conversation

@ralph-bitgo

@ralph-bitgo ralph-bitgo Bot commented Sep 8, 2026

Copy link
Copy Markdown

What

  • Add optional blockHeight to RecoverParams and the pre-derived recovery parameters.
  • Thread the value through backup-key recovery into Zcash PSBT construction.
  • Verify a post-NU6.2 height selects branch ID 0x5437f330.

Why

Non-BitGo ZEC recoveries omitted a current height and used the stale NU6.1 fallback, causing transactions to be rejected by NU6.2 nodes.

Verification

  • yarn workspace @bitgo/abstract-utxo build
  • BITGOJS_TEST_PASSWORD=test-password yarn workspace @bitgo/abstract-utxo unit-test --grep "uses the supplied post-NU6.2 block height"

Ticket: SC-7552

Add blockHeight to public recovery parameters and thread it into the Zcash PSBT builder. Add coverage for the NU6.2 branch ID at the activation height.

Non-BitGo ZEC recovery callers need an independent current height because the legacy fallback builds transactions with the stale NU6.1 branch ID.

Ticket: SC-7552
Session-Id: c182a31e-f1d9-452c-8696-c45ca8abf89c
Task-Id: f34a63ab-cb0f-45a1-9390-e1f127e4275a
@linear-code

linear-code Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

SC-7552

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant