fix: address js-yaml and extract-zip security advisories - #9690
Merged
Conversation
## Problem GHSA-2883-xcg3-v3hh affects js-yaml <4.3.2. GHSA-7pqw-9j4j-h8q3 affects extract-zip through 2.0.1 with no patched release available. ## Goal Clear the blocking OSV findings for both advisories. ## Fix - Pin js-yaml to 4.3.2 via resolutions/overrides and refresh yarn.lock - Ignore GHSA-7pqw-9j4j-h8q3: extract-zip is transitive via cypress and @puppeteer/browsers (browser-test only); no upstream fix beyond 2.0.1 ## Testing Verified yarn.lock resolves all js-yaml ranges to 4.3.2; confirmed extract-zip parents are browser-test tooling only. Ticket: CSHLD-1698
diksha190
approved these changes
Sep 9, 2026
diksha190
left a comment
diksha190
left a comment
There was a problem hiding this comment.
Approved
This security fix directly addresses two disclosed vulnerabilities:
- js-yaml (GHSA-2883-xcg3-v3hh): Pinning from 4.3.1 → 4.3.2 resolves the arbitrary code execution risk.
- extract-zip (GHSA-7pqw-9j4j-h8q3): Correctly identified as dev-only (Cypress, Puppeteer). Documented exclusion with clear dates and conditions.
mukeshsp
approved these changes
Sep 9, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GHSA-2883-xcg3-v3hh affects js-yaml <4.3.2. GHSA-7pqw-9j4j-h8q3 affects extract-zip through 2.0.1 with no patched release available.
Goal
Clear the blocking OSV findings for both advisories.
Fix
Testing
Verified yarn.lock resolves all js-yaml ranges to 4.3.2; confirmed extract-zip parents are browser-test tooling only.
Ticket: CSHLD-1698