Repository navigation
fix(updater): hold update overlay until the whole update finishes - #353
Merged
Merged
Conversation
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep the update overlay up until install-updater and the daemon restart finish (capped at 180s), and add a hermetic end-to-end updater integration suite.
Changes
daemon_restartinginstead of dropping it mid-updatetests/integration/updater/: hermetic end-to-end suite (real git remotes, faked systemctl/sudo/apt/pip), 29 tests covering update, rollback, branch switch, deploy handoff, boot reconcile, provisioning, cancelmake test-integrationrunstests/integration/; the NetworkManager suite moved tomake test-integration-nmMotivation
After an update that touched the installer, the overlay dropped while install-updater was still running, so the screen unlocked and briefly showed a provisioning step mid-update.
Tests
test_install_update_holds_overlay_until_deploy_finishes