Skip to content

fix(updater): hold update overlay until the whole update finishes - #353

Merged
gmmcosta15 merged 7 commits into
devfrom
fix/updater-install-overlay
Oct 19, 2026
Merged

gmmcosta15 merged 7 commits into
devfrom
fix/updater-install-overlay

Conversation

@gmmcosta15

Copy link
Copy Markdown
Collaborator

Description

  • Feature
  • Bug Fix
  • Code Refactor
  • Documentation

Keep the update overlay up until install-updater and the daemon restart finish (capped at 180s), and add a hermetic end-to-end updater integration suite.

Changes

  • Daemon stays busy while install-updater runs (deploy flag + BlocksScreen-deploy.path), polled every 1s, capped at 180s so a hung deploy never locks the screen
  • Restarted daemon resumes the hold silently at init; first status emit waits for the boot pass
  • UI keeps the update overlay through daemon_restarting instead of dropping it mid-update
  • tests/integration/updater/: hermetic end-to-end suite (real git remotes, faked systemctl/sudo/apt/pip), 29 tests covering update, rollback, branch switch, deploy handoff, boot reconcile, provisioning, cancel
  • make test-integration runs tests/integration/; the NetworkManager suite moved to make test-integration-nm

Motivation

After an update that touched the installer, the overlay dropped while install-updater was still running, so the screen unlocked and briefly showed a provisioning step mid-update.

Tests

  • Overlay hold mutation-checked: disabling it fails test_install_update_holds_overlay_until_deploy_finishes

@gmmcosta15 gmmcosta15 added bug Something is broken, or a fix for it updater Field updates and self-heal labels Oct 16, 2026
@gmmcosta15 gmmcosta15 self-assigned this Oct 16, 2026
@gmmcosta15 gmmcosta15 changed the title fix: fix(updater): hold update overlay until the whole update finishes fix(updater): hold update overlay until the whole update finishes Oct 16, 2026

@RobeMartins RobeMartins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmcosta15
gmmcosta15 merged commit 52e810b into dev Oct 19, 2026
9 checks passed
@gmmcosta15
gmmcosta15 deleted the fix/updater-install-overlay branch October 19, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken, or a fix for it updater Field updates and self-heal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants