Repository navigation
fix(configurator): write printer.cfg atomically at boot - #361
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At boot,
ConfigManager.merge_cfgoverwrote printer.cfg in place. If power was lost during that write, printer.cfg was left truncated. The next boot then rebuilt it from the repo and lost the SAVE_CONFIG block (z offset, beacon calibration). merge_cfg now writes through the same atomic helperdevice_configurator.pyalready used, moved intohelper_methods.pyso both modules share it.Changes
atomic_write_textmoved fromdevice_configurator.pytohelper_methods.pyConfigManager.merge_cfgwrites through it (temp file + fsync +os.replace, mode and symlink kept)Motivation
merge_cfg rewrote printer.cfg in place. A power cut during the first boot after an update truncated it, and the next boot rebuilt it from the repo, losing SAVE_CONFIG data (z offset, beacon calibration).