Repository navigation
fix(scripts): offer repo teams as reviewers in make pr - #368
Merged
Merged
Conversation
gmmcosta15
added
bug
RobeMartins
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make prbuilds its reviewer list fromrepos/{repo}/collaborators, an endpoint that only returns users, soBlocksTechnology/devteam(the team every PR requests) could never be picked. It had to be added on GitHub after the PR was open. This PR adds the repo's teams to the top of the reviewer list asowner/slug, whichgh pr edit --add-revieweraccepts unchanged.Changes
repos/{repo}/teamsbefore the collaborators in the Reviewers picker; skipped silently when the call fails (personal repos have no teams)Motivation
A team request reaches every member, so picking it is the common case.
Tests
shellcheck scripts/create-pr.shclean;bash -nokBlocksTechnology/devteam; against a repo that returns 404 it adds nothing and prints nothing