API: Update code to match SIMPLNX MessageHandler API changes - #24
Merged
Merged
Conversation
…thms Brings these filters in line with the simplnx progress-messaging rules. InterpolateValuesToUnstructuredGrid had three defects. Its thread-safe seam read the clock itself and the comparison was inverted, returning when a message was due, so it flooded for one second and then went silent for the rest of the run while the filter kept working. It reported 100 percent even when the workers had returned early because the user cancelled. It reported an array as complete before copying it. The seam now uses the shared throttle, completion is reported only when the run was not cancelled, and the array count follows the copy. The worker keeps its count stride but no longer reads the clock, and it flushes its pending count on the cancellation path instead of discarding it. MergeColonies, ComputeMicroTextureRegions, ComputeSaltykovSizes and ComputeLocalAverageCAxisMisalignments ran whole-volume and per-feature passes with no messages, and in several cases no cancellation check either. Each now announces its phases and reports its outer work unit. The Saltykov fitting loop has no honest denominator, so it sends throttled free-form status, while its quadratic matching phase reports a real percentage. Two corrections from review of that work. The per-cell loops in MergeColonies reported and polled cancellation on every cell, which on a large volume is a billion added reporting paths per pass; they now use a count stride. The final remap writes a cell parent id and its feature-level parent id together, so returning part way leaves the two inconsistent with nothing to restore either; that pass now honours cancellation before it begins and then runs to completion. Several phases declared N units while iterating a range starting at one, so the bar could never pass (N-1)/N, and reports were placed before the work they described rather than after. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.