Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions recipes/libs/sharness.yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this to recipes/devel/sharness.yaml because it's a development tool.

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
inherit: [make]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the standard meta variables.

checkoutSCM:
scm: git
url: ${GITHUB_MIRROR}/felipec/sharness.git
tag: v1.2.1
shallow: 1
Comment on lines +4 to +7

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally prefer tarballs whenever possible. That makes mirroring easier and has usually less overhead.

Suggested change
scm: git
url: ${GITHUB_MIRROR}/felipec/sharness.git
tag: v1.2.1
shallow: 1
scm: url
url: ${GITHUB_MIRROR}/felipec/sharness/archive/refs/tags/v${PKG_VERSION}.tar.gz
digestSHA256: ...
stripComponents: 1


buildScript: |
make -C "$1" install prefix=/usr DESTDIR="$PWD/install"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use makeParallel or makeSequential. A plain make will behave differently if started with a job server or without.


packageScript: |
cp -a "$1/install/." .
Loading