Skip to content

input: split into package - #735

Merged
jkloetzke merged 1 commit into
BobBuildTool:masterfrom
jkloetzke:refactor-input-module
Nov 11, 2026
Merged

jkloetzke merged 1 commit into
BobBuildTool:masterfrom
jkloetzke:refactor-input-module

Conversation

@jkloetzke

Copy link
Copy Markdown
Member

The bob.input module had grown to almost 5000 lines. Split it into a package with submodules for plugins, checkout, core items, packages, validators, recipes, the YAML cache and the recipe set. All definitions are moved verbatim.

The package re-exports the public API used by plugins, so "from bob.input import X" keeps working. Names that bob.input merely imported from other modules (e.g. Env, GitScm) are not re-exported anymore. Tests import them from their real location now.

@codecov

codecov Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.29937% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.37%. Comparing base (b3e834b) to head (13be496).

Files with missing lines Patch % Lines
pym/bob/input/recipeset.py 91.31% 52 Missing ⚠️
pym/bob/input/package.py 95.22% 27 Missing ⚠️
pym/bob/input/recipe.py 97.64% 20 Missing ⚠️
pym/bob/input/cache.py 90.32% 12 Missing ⚠️
pym/bob/input/validators.py 91.48% 12 Missing ⚠️
pym/bob/input/common.py 81.03% 11 Missing ⚠️
pym/bob/input/core.py 95.81% 10 Missing ⚠️
pym/bob/input/checkout.py 90.62% 6 Missing ⚠️
pym/bob/input/plugins.py 92.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   90.34%   90.37%   +0.02%     
==========================================
  Files          50       59       +9     
  Lines       17238    17301      +63     
==========================================
+ Hits        15574    15636      +62     
- Misses       1664     1665       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkloetzke

Copy link
Copy Markdown
Member Author

@rhubert @sbixl @mahaase Could you have a look if this breaks any plugins on your side?

@rhubert

rhubert commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Can you push it to a branch in BobBuildTool/bob repository? (Only this is mirrored in our development network...)

@jkloetzke

Copy link
Copy Markdown
Member Author

Can you push it to a branch in BobBuildTool/bob repository? (Only this is mirrored in our development network...)

Sure -> https://github.com/BobBuildTool/bob/tree/refactor-input-module

@rhubert

rhubert commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Thanks - I switched to this branch this morning. So far I found no issues, no plugin adaptions were required.

The bob.input module had grown to almost 5000 lines. Split it into a
package with submodules for plugins, checkout, core items, packages,
validators, recipes, the YAML cache and the recipe set. All definitions
are moved verbatim.

The package re-exports the public API used by plugins, so "from
bob.input import X" keeps working. Names that bob.input merely imported
from other modules (e.g. Env, GitScm) are not re-exported anymore. Tests
import them from their real location now.
@jkloetzke
jkloetzke force-pushed the refactor-input-module branch from ebf8abc to 13be496 Compare November 10, 2026 20:47
@jkloetzke

Copy link
Copy Markdown
Member Author

Thanks for testing. In case something breaks, we could add more exports to the bob.input module again.

@jkloetzke
jkloetzke merged commit 0155acd into BobBuildTool:master Nov 11, 2026
11 checks passed
@jkloetzke
jkloetzke deleted the refactor-input-module branch November 11, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants