Repository navigation
input: split into package - #735
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Can you push it to a branch in |
Sure -> https://github.com/BobBuildTool/bob/tree/refactor-input-module |
|
Thanks - I switched to this branch this morning. So far I found no issues, no plugin adaptions were required. |
The bob.input module had grown to almost 5000 lines. Split it into a package with submodules for plugins, checkout, core items, packages, validators, recipes, the YAML cache and the recipe set. All definitions are moved verbatim. The package re-exports the public API used by plugins, so "from bob.input import X" keeps working. Names that bob.input merely imported from other modules (e.g. Env, GitScm) are not re-exported anymore. Tests import them from their real location now.
ebf8abc to
13be496
Compare
|
Thanks for testing. In case something breaks, we could add more exports to the bob.input module again. |
The bob.input module had grown to almost 5000 lines. Split it into a package with submodules for plugins, checkout, core items, packages, validators, recipes, the YAML cache and the recipe set. All definitions are moved verbatim.
The package re-exports the public API used by plugins, so "from bob.input import X" keeps working. Names that bob.input merely imported from other modules (e.g. Env, GitScm) are not re-exported anymore. Tests import them from their real location now.