Repository navigation
Parallel upload - #737
Merged
Merged
Parallel upload#737
Conversation
In parallel builds the UPLOAD of a package had to finish before any dependent step could start. Run the upload as a separate task instead so that the build can proceed. The upload still occupies a job slot to honour the configured number of jobs. Pending uploads are waited for at the end of the build, even if the build failed or is restarted, so that successfully built packages are not lost. Sequential builds (-j1) keep uploading inline. Shared packages are now installed before the upload. The installation may move the workspace to the shared location, which must not race with a running upload. The upload then reads the package from the shared location. Fixes BobBuildTool#695.
The upload command of the archive waits until the dependent package was built. This only succeeds if the upload runs in the background. Also check that failing background uploads still fail the build.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 90.31% 90.34% +0.02%
==========================================
Files 50 50
Lines 17217 17238 +21
==========================================
+ Hits 15550 15573 +23
+ Misses 1667 1665 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upload packages in parallel to dependent packages.