Repository navigation
Conversation
The live build-id was predicted by hashing the 'url' relative to the current working directory. This ignores the project root and the 'recipeRelative' option. Hash the actual source directory instead.
Sometimes only some files of a directory are needed by a package, e.g.
a single defconfig file. Putting such files into a common directory that
is imported by multiple packages causes all of them to be rebuilt if any
file is changed.
Add a 'filter' attribute to the import SCM that takes an ordered list of
rsync-like include/exclude rules. Both the short ("+ PATTERN",
"- PATTERN") and the long form ("include PATTERN", "exclude PATTERN") are
supported. The first matching rule decides and excluded directories are
not traversed, just like rsync does. The new 'pruneEmptyDirs' option
skips empty directories, regardless of whether a filter is used or not.
The selection is computed in one place and used for local imports,
Jenkins builds and the live build-id prediction. The options are only
added to the digest if they are used. This keeps the variant-id of
existing recipes stable.
Fixes BobBuildTool#657.
Verify the rsync-like matching rules, pruneEmptyDirs and that local imports, Jenkins builds and the live build-id prediction agree. The black box test checks that packages which import different files from the same directory are only rebuilt if their files change.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #741 +/- ##
==========================================
+ Coverage 90.39% 90.45% +0.05%
==========================================
Files 59 59
Lines 17404 17551 +147
==========================================
+ Hits 15733 15875 +142
- Misses 1671 1676 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #657.