Repository navigation
Match replay grip conventions to the tire model - #131
Open
rhorvath02 wants to merge 1 commit into
Open
rhorvath02 wants to merge 1 commit into
rhorvath02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replay uses the same MF peak coefficients and contact threshold as DynPy. It no longer adds a minimum friction coefficient or treats a loaded tire below 10 N as airborne. Zero capacity is shown as unavailable. The display identifies the ellipses as approximate.
Stacked on #130.
How to check
42 focused tire and replay tests pass, with 3 skips. The editor behavior test, lint, type checking, and JavaScript syntax checks pass. Existing MF52 force checks cover the shared coefficient calculation.
CI
GitHub lint, type checking, full tests, and PR-description checks pass. Container-toolchain CI is blocked by the OpenModelica download timeout.