feat(tron): add settlement pending receipt handling - #98
Merged
Merged
Conversation
# Conflicts: # typescript/packages/mechanisms/tron/src/exact/facilitator/eip3009.ts # typescript/packages/mechanisms/tron/src/gasfree/facilitator/scheme.ts # typescript/packages/mechanisms/tron/src/signer.ts
Will-Guan
reviewed
Sep 3, 2026
Will-Guan
reviewed
Sep 3, 2026
Will-Guan
reviewed
Sep 3, 2026
Will-Guan
reviewed
Sep 3, 2026
Will-Guan
reviewed
Sep 3, 2026
Will-Guan
reviewed
Sep 3, 2026
Contributor
|
This review identified six issues: three P1, two P2, and one P3. The main problem is that
Together, the P1 issues allow unresolved on-chain operations to lose their reconciliation identity, become eligible for replacement, or be broadcast again. This can produce duplicate transaction attempts, additional fees, repeated resource execution, and divergence between local and on-chain state. The existing relevant tests pass, but they do not cover these cross-layer pending-state scenarios. Review recommendation: Request changes. |
Will-Guan
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align TRON settlement_pending behavior with the existing EVM receipt handling model.
Supersedes #97 after the feature branch was renamed.
Tests
Branch route
Checklist