Skip to content

feat(Live2DDisplay): fingerprint CSS asset - #1238

Merged
ArgoZhang merged 3 commits into
masterfrom
dev-Live2DDisplay
Oct 23, 2026
Merged

ArgoZhang merged 3 commits into
masterfrom
dev-Live2DDisplay

Conversation

@ArgoZhang

@ArgoZhang ArgoZhang commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Link issues

fixes #1237

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enable Live2D display to load its CSS asset through framework-aware URLs.

New Features:

  • Support fingerprinted Live2D display CSS asset URLs on .NET 9 and later.

Enhancements:

  • Pass the resolved stylesheet URL through Live2D initialization so CSS assets load correctly across supported target frameworks.

Build:

  • Update the Live2D display project configuration to support the fingerprinted asset.

@sourcery-ai

sourcery-ai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR makes Live2DDisplay load its CSS through a runtime-provided asset URL, using the .NET 9 asset manifest for fingerprinting while retaining the existing static path on older targets, and forwards that URL into the JavaScript initializer.

Sequence diagram for fingerprinted Live2DDisplay CSS loading

sequenceDiagram
    participant Live2DDisplay
    participant Live2DDisplayJS
    participant Browser
    Live2DDisplay->>Live2DDisplay: InvokeInitAsync()
    alt NET9_0_OR_GREATER
        Live2DDisplay->>Live2DDisplay: Assets[StylePath]
    else Older target
        Live2DDisplay->>Live2DDisplay: StylePath
    end
    Live2DDisplay->>Live2DDisplayJS: init(op, styleUrl)
    Live2DDisplayJS->>Browser: addLink(styleUrl)
Loading

File-Level Changes

Change Details Files
Resolve the Live2D stylesheet URL through the generated asset manifest on .NET 9 and pass it into JavaScript initialization.
  • Define a shared CSS asset path and conditionally map it through the asset manifest for .NET 9.
  • Pass the resolved stylesheet URL from the component to the JavaScript initializer.
  • Update JavaScript initialization to load the supplied stylesheet URL instead of a hard-coded path.
src/components/BootstrapBlazor.Live2DDisplay/Components/Live2DDisplay/Live2DDisplay.razor.cs
src/components/BootstrapBlazor.Live2DDisplay/Components/Live2DDisplay/Live2DDisplay.razor.js
Update project configuration to support fingerprinted CSS asset packaging.
  • Adjust the component project configuration for the fingerprinted asset delivery path.
src/components/BootstrapBlazor.Live2DDisplay/BootstrapBlazor.Live2DDisplay.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#1237 Use a fingerprinted URL when loading the Live2DDisplay CSS asset. ✅

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto Bot added the enhancement New feature or request label Oct 23, 2026
@bb-auto bb-auto Bot added this to the v10.0.0 milestone Oct 23, 2026

@bb-auto bb-auto Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved by bb-auto

@ArgoZhang
ArgoZhang merged commit 2f7afa8 into master Oct 23, 2026
3 checks passed
@ArgoZhang
ArgoZhang deleted the dev-Live2DDisplay branch October 23, 2026 02:29

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Live2DDisplay): fingerprint CSS asset

1 participant