Repository navigation
feat(Live2DDisplay): fingerprint CSS asset - #1238
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR makes Live2DDisplay load its CSS through a runtime-provided asset URL, using the .NET 9 asset manifest for fingerprinting while retaining the existing static path on older targets, and forwards that URL into the JavaScript initializer. Sequence diagram for fingerprinted Live2DDisplay CSS loadingsequenceDiagram
participant Live2DDisplay
participant Live2DDisplayJS
participant Browser
Live2DDisplay->>Live2DDisplay: InvokeInitAsync()
alt NET9_0_OR_GREATER
Live2DDisplay->>Live2DDisplay: Assets[StylePath]
else Older target
Live2DDisplay->>Live2DDisplay: StylePath
end
Live2DDisplay->>Live2DDisplayJS: init(op, styleUrl)
Live2DDisplayJS->>Browser: addLink(styleUrl)
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #1237
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable Live2D display to load its CSS asset through framework-aware URLs.
New Features:
Enhancements:
Build: