Skip to content

Team mode M2: Private Bots, per-member Tob, per-member Activity and push #4141

Closed

Description

@DoodleBears

Parent: hub #4138 (spec #4137, ADR-0336). Blocked by: #4140.

Behavior

  • PersonaBots gain owner_human_id; existing Bots migrate to the Owner. Private visibility is enforced.
  • Each member gets a private Tob automatically. It acts with that member's authority and never above it.
  • Activity, counts and push are scoped per Human ID. Bot Inbox Source Events carry the speaking Human.

Acceptance

  • Bob cannot list, open or DM Alice's private Bot through the Client, the CLI with --as, or Bot tools.
  • Bob's Tob cannot read Alice's content.
  • Activity counts are per member.
  • Push reaches only the member's own devices.

Activity

  1. DoodleBears commented on Nov 13, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim

    • Agent: Claude Code (orchestrator, UI/UX) + Codex CLI (logic)
    • Task: claude/local/74a5ee4a-f6fe-4aab-870f-5e465b0b8474 (not a DSH Session); Codex thread added once started
    • Issue scope: M2 per the contract below
    • Branch: claude/4141-private-bots (stacked on claude/4140-team-sign-in, PR Team mode M1: members sign in over HTTPS and talk in public channels #4163; Codex sub-branch codex/4141-logic)
    • Started: 2026-11-13 23:06 UTC
    • State: active

    M2 wire contract (agreed before parallel work; Claude = UI, Codex = logic)

    Stacked on M1 (#4163). Independent of M3; when M3 lands, Bot creation is additionally gated by bots.create.

    Ownership

    • PersonaBots gain owner_human_id (existing Bots migrate to local-human). In M2 every member Bot is private: only its owner (and the Host Owner, for administration in Bot settings only, not content) can list, open, DM, edit or delete it. Visibility roles/shared is M7.
    • Bot summaries on the wire gain ownerHumanId and owner: boolean (the caller owns it). The Owner's roster still lists only the Owner's own Bots by default.
    • A member Bot joins only Channels its owner belongs to; group membership and @mentions of a private Bot by anyone else are refused (bot-not-found — do not reveal existence).

    Per-member Tob

    • Each member gets a private Tob on first successful sign-in (idempotent). Tob acts with that member's authority: it sees only that member's Bots, Channels and Activity, and its management tools refuse anything the member could not do through the Client. Tob's Host-administration tools (models, plugins, Team mode, other members, IM apps, devices, data reset) are unavailable to member Tobs (permission-required).

    Per-member Activity, read state and push

    • humanAttention*, activitySnapshot, followActivity, channelUnreadCounts are scoped to the calling Human; Owner attention never appears for a member (fixes the M1 audit finding on humanAttentionStatus).
    • Push and Live Activity delivery go only to devices whose grant belongs to the Human the item is for. M8 brings member phones; in M2 prove the routing with the Owner plus a member grant fixture.
    • Bot Inbox stays per Bot; Source Events already carry the speaking Human (M0).

    Member allowlist additions (team/member-methods.ts): own-Bot methods (bot list/get/create/delete/rename/settings the Client calls for a DM Bot, botStop, botAttention, botSessionIds for own Bots), Bot DM open/send, humanAttention, humanAttentionStatus, humanAttentionDismiss, humanAttentionDismissAll, humanAttentionIgnore, humanAttentionSnooze, activitySnapshot, followActivity, onboarding (member-scoped), and the Bot creation path. Every Bot-addressed method checks ownership; list the exact names in member-methods.ts and the claim follow-up comment.

    CLI: bots list|create|delete honour the caller (--as), bots show refuses another member's Bot with bot-not-found; activity list --as <member> shows only that member's items.

    Client (Claude): member New menu offers Create Bot; member sidebar shows own Bots and own Tob; Activity rail works for members; Bot settings for a member Bot; removes M1's member-only Bot/Activity suppressions where M2 enables them; empty states for members; en + zh.

    Tests: Bob cannot list, open, DM, mention or add Alice's private Bot (Client, --as, and a Bot tool call); Bob's Tob cannot read Alice's content; Activity counts per member; push routed only to the owner's devices.

  2. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 13, 2026
  3. DoodleBears commented on Nov 13, 2026

    @DoodleBears
    ContributorAuthor

    Codex logic task for this claim: codex/local/01a1d729-cdcb-7e73-9369-c625a4e90635 on codex/4141-logic (gpt-6.1-sol, high).

  4. DoodleBears commented on Nov 14, 2026

    @DoodleBears
    ContributorAuthor

    Outcome

    Merged in #4166 (2d1747902). Each member has their own Tob and private Bots, invisible to other members and the Owner's sidebar through list, get, DM and CLI --as; bots.create gates creation; attention and push are per Human. Verified on a real isolated Host with Owner + two member browsers; CI green; 8 review findings fixed with regressions.

    State: done. Claim released.

  5. DoodleBears commented on Nov 14, 2026

    @DoodleBears
    ContributorAuthor

    Amended after merge by the Bot access model on spec #4137 (2026-11-15): private Bots now follow their principal (read any Channel the principal can access; write only where added; anyone in that Channel may @ them; only the principal may DM them); member Tobs are no longer created automatically (M13 #4187). Implementation of the changes lands in M13 and M7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDsfeature:teamready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions