Skip to content

[Permissions E1] 统一工具效果声明与审批决策,保持现有行为 #4205

Closed

Description

@DoodleBears

Parent

#4203

适用已确认的 ADR-0342 与 Bot 审批目标设计。旧父规格中的两层叠加及每次 Human 限制不替代此次确认的选择关系与 ADR-0249 边界。

What to build

复用既有准备票;使第一方工具通过统一效果声明与决策路径保留原审批和 Grant 行为,供外部效果准入复用。此票是准备工作,不宣称完成用户功能。

Acceptance criteria

  • 公开效果模型、每个第一方工具的声明及漏声明 lint;声明随参数变化时保持正确。
  • 既有直接工具 CLI 与审批 journey 的可观察结果保持一致;管理、Secret、设备与 Grant 保护不退化。
  • 不增加模型调用;保持现有行为回归,并记录确定性热路径的性能影响。
  • 只替换有已覆盖调用方的特例;不把尚未迁移的识别入口提前删除。

Blocked by

None (can start immediately).

发布仅表示可供 Agent 接手,不代表解除阻塞、已认领实施或已获运行权限变更授权;不推进 SQLite 迁移。新增或改变 Host 能力需同票交付在线 CLI,真实 Host 与 Client 验收、性能影响与回归保护随切片完成。

来源限定的验收记录(2026-11-16)

E1 已由 PR #4249 合并。声明、准入与保护的结论来自 E1 的 focused/真实 CLI 证据及后续集成审查。

勾选针对上述来源范围,不表示所有平台、最新 APK 或未运行的测量均通过。剩余 iOS、当前源冷路径及三项匹配性能验收见 QA #2742。最终实现与源码限定说明见 PR #4266;本记录不改变原有规格正文。

Activity

  1. added this to the v2.0 milestone on Nov 14, 2026
  2. added
    ready-for-agentFully specified, ready for an AFK agent
    area:backendHost-side implementation
    feature:workspaceWorkspace Grant and working-directory authority
    scope:foundationFoundational authority, runtime, or infrastructure
    on Nov 14, 2026
  3. changed the title [-][Permissions E1] ToolEffects 与审批决策函数[/-] [+][Permissions E1:统一工具效果声明与审批决策,保持现有行为[/+] on Nov 15, 2026
  4. changed the title [-][Permissions E1:统一工具效果声明与审批决策,保持现有行为[/-] [+][Permissions E1] 统一工具效果声明与审批决策,保持现有行为[/+] on Nov 15, 2026
  5. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim

    • Agent: Codex
    • Task: codex/local/01a1df40-f4f6-7a32-9cd2-245844776694 (not a DSH Session)
    • Issue scope: E1 public ToolEffects declarations, missing-declaration lint and covered deterministic approval decisions; preserve runtime/Grant behavior, no E2/E3 or SQLite migration.
    • Branch: t3/tool-effects-approval
    • Started: 2026-11-15 12:49 UTC
    • State: active
  6. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 15, 2026
  7. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim

    • Agent: Codex
    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c (not a DSH Session)
    • Issue scope: Parent review fixes only: bridge_context remote scopes, unarchive_assignment message effects, and secret_http method normalization found at PR refactor(approval): unify tool effects and preserve existing decisions (E1) #4249 head 050846a. Separate worktree; implementation delegate retains runtime/visual verification and PR ownership.
    • Branch: t3/bot-auto-approval-design
    • Started: 2026-11-15T13:52:05.870Z
    • State: active
  8. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work handoff

    • Agent: Codex
    • Task: codex/local/01a1df40-f4f6-7a32-9cd2-245844776694
    • State: handed-off
    • PR: refactor(approval): unify tool effects and preserve existing decisions (E1) #4249
    • Head: af55a27a657967765195e8f8737409bb66ea29d3
    • Delivered: E1 public effect model, first-party declarations/lint, explainable compatibility decisions and covered owner regression paths. Parent's three declaration corrections were cherry-picked from d62bbe9 as af55a27, preserving its task trace.
    • Checks: 23 focused approval/Grant files, 376 tests passed; full typecheck, lint and build passed. Current CI read passed build/type/format/docs/mobile/native/Host-smoke/performance-budget/shard-3; shards 1/2 were still running. The earlier broad local run was cancelled after failures and source edits, and is not a final gate.
    • Runtime: real isolated base and corrected-head Hosts, model-free direct request_workspace_grant, canonical request/trace and empty Grant readback. Matched zh-CN/dark card screenshots are embedded in the PR with verified public R2 readback. This is existing Grant-card presentation verification, not E2 admission or a model-path claim.
    • Cleanup: all owned Hosts/children/drivers exited, owned preview tab closed, ports 36051/36052/36053 free; closed Profiles and private provenance retained. Earlier unmodified Windows lifecycle attempt is documented; qualified launches used only the parent-provided native preload.
    • Remaining parent gates: exact-current-head HTML explainer, remaining CI/review/Human acceptance and merge decision. No merge or watch was performed. agent:active is retained for the parent's active claim.
  9. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome

  10. removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:backendHost-side implementationfeature:workspaceWorkspace Grant and working-directory authorityready-for-agentFully specified, ready for an AFK agentscope:foundationFoundational authority, runtime, or infrastructure

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions