Skip to content

[Permissions] 模板编写:显式创建来源、三部分编辑与应用 #4244

Closed

Description

@DoodleBears

Parent

#4203

适用已确认的 ADR-0342 与 Bot 审批目标设计。旧父规格中的两层叠加及每次 Human 限制不替代此次确认的选择关系与 ADR-0249 边界。

What to build

用户从零创建或明确选择来源创建独立副本,在 Always ask/Always allow/free text 中编写策略,并明确选择仅保存或保存并用于当前 Bot;可明确编辑共享原件并看到影响范围。

Acceptance criteria

  • CLI 与 Client 完整覆盖空白创建、基于所选模板复制、三部分编辑及读回;副本无持续来源关联。
  • 仅保存不改变 Bot;保存并应用才切换。编辑共享原件与复制新模板是显式不同操作,披露所有实际使用者。
  • Reviewer 消费三部分指导:Always ask 优先、Always allow 次之,free text 补充;冲突、不覆盖或不确定转 Human,不宣称模型必然理解正确。
  • 用一次真实请求贯通内容保存到 Reviewer 判断,固定版本和管理授权边界不退化。
  • 提供中英文示例及简短解释;不丢旧内容,不在本票决定数据库迁移或宣称新旧模型行为完全相同。
  • 验证现有旅程前后基线,新增编辑和装配工作单独预算;不把任何模型判断编译为确定性授权。

Blocked by

发布仅表示可供 Agent 接手,不代表解除阻塞、已认领实施或已获运行权限变更授权;不推进 SQLite 迁移。新增或改变 Host 能力需同票交付在线 CLI,真实 Host 与 Client 验收、性能影响与回归保护随切片完成。

来源限定的验收记录(2026-11-16)

模板编写已由 PR #4261 合并。三部分真实 Review、版本/副本/显式应用证据及43/e40 V2 DOM opening配对保留来源;旧失败未改判。该 DOM 计时不代表原生 FPS 或最新 head 的性能。

勾选针对上述来源范围,不表示所有平台、最新 APK 或未运行的测量均通过。剩余 iOS、当前源冷路径及三项匹配性能验收见 QA #2742。最终实现与源码限定说明见 PR #4266;本记录不改变原有规格正文。

Activity

  1. added this to the v2.0 milestone on Nov 15, 2026
  2. added
    ready-for-agentFully specified, ready for an AFK agent
    area:ui-uxInteraction and visual experience; may accompany a code-layer area
    area:fullstackEnd-to-end Host and Client implementation
    feature:workspaceWorkspace Grant and working-directory authority
    on Nov 15, 2026
  3. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim

  4. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 15, 2026
  5. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome

    • Agent: Codex
    • Task: codex/local/t3-4d0dd206-86059e8a3599fc27 (not a DSH Session)
    • State: handed-off
    • Issue scope: [Permissions] 模板编写:显式创建来源、三部分编辑与应用 #4244 explicit blank/source creation, independent copies, three-part guidance, save-only/current-Bot apply, and shared-original usage disclosure.
    • Branch: t3/approval-template-management
    • Commit: b7cdf08c436e7777cbb95a989eb21f1b53365234 (local commit-only handoff; parent Spec: 工具效果声明与 Bot 权限策略(Always allow / Always ask / 其他判断) #4203 owns integration/review/publication).
    • Validation: final-head production build, 60 focused tests, changed-file lint/format and structural guards passed. Real authenticated CLI and Web administration passed. Eleven genuine privacy-reviewed screenshots and an exact-head HTML explainer were published to R2 with hash/decode/readback verification.
    • Remaining acceptance: a real model DM worked, but the safe todo_write probe raised no approval request, so live saved-content → captured Review → allow-once/ask-human is not claimed. Parent needs an authorized pending-request fixture. Root typecheck fails on an Expo Router import outside this diff. Native/Human acceptance and E3 PR4250 final qualification remain parent-owned; dependency is not claimed merged.
    • Cleanup: task Host, browser drivers and owned tab stopped; task ports released; private Profile/evidence preserved. No push, PR, watch, merge or issue closure.
  6. removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 15, 2026
  7. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim — parent review fixes

    • Agent: Codex parent
    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c (not a DSH Session)
    • Branch: t3/approval-template-management, clean source returned at b7cdf08c.
    • Scope: fix two confirmed P2 findings: reject ambiguous CLI creation sources before any save/apply; recognize Windows newlines and reject invalid marked guidance instead of treating it as legacy Markdown. Repair the checkout-local Expo Router patch installation and rerun qualification.
    • State: active. Live captured Reviewer, integration, final runtime/native evidence, PR/CI/merge remain parent-owned.
  8. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 15, 2026
  9. DoodleBears commented on Nov 15, 2026

    @DoodleBears
    ContributorAuthor

    #4244 implementation update

    Delivered as Draft PR #4261 on frozen head 43cfc1b7d9a176bcb98b1b6e8fe806fc526990b2, stacked on #4250. Three-part guidance, explicit blank/copy and save/apply, grouped rule rows and keyboard focus are implemented.

    Current Web/CLI/real Reviewer proof and exact-head R2 media are recorded in the PR. A new full-text protocol completed one matched DOM-ready pair within the unchanged1500ms budget; old timeout/fixture failures remain retained. Ten embedded images were verified loading in GitHub.

    CI is in progress. Android/iOS and final Human acceptance remain pending; no merge or native-pass claim.

  10. 5 remaining items

  11. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome

    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c (not a DSH Session).
    • State: completed for implementation; remaining verification is explicitly retained in QA.
    • Delivery: PR #4261, with final integration/review fixes in PR #4266, head f1172fdaa3c40b2ace8473fc8152cce3da3e83e2, merge da257ad8b9317e41d2f14dce2fe63b9abe7c2202. Final CI result 11 executed CI checks passed; 4 checks were explicitly skipped, including paused CodeRabbit; independent Spec/Standards rechecks have 0 unresolved findings. CodeRabbit current-head status is recorded separately, not counted as a review pass when skipped.
    • Human accepted the physical Android retained full-card/details/disabled-selected-result experience at source a541133. Runtime/component/source qualifications remain explicit in the PR, not extrapolated to a new iOS run.
    • 来源限定的实现验收见已更新清单。 Full QA, current cold follow-up and three matched-performance gaps remain #2742. Unmeasured criteria stay unchecked; historical failures are retained.
    • Parent integrated the returned delegated sources and completed the live caller-bound/managed admission proofs, review repairs, screenshots/HTML and cleanup. Task-owned resources are stopped; Profiles/evidence remain under the QA hold. No SQLite migration was advanced.

    The implementation ticket closes on feature merge under repository policy. This outcome does not claim every platform or pending metric passed.

  12. removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 16, 2026
  13. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim — rule number alignment

    • Agent: Codex
    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c (not a DSH Session)
    • Scope: Human-requested follow-up: align Always ask / Always allow rule numbers with the first text line in the grouped editor. Existing template semantics and saved content stay unchanged.
    • Branch: t3/bot-auto-approval-design (existing thread-bound worktree)
    • Started: 2026-11-16T12:00:47.890Z
    • State: active
  14. added
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 16, 2026
  15. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work update — rule number alignment

    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c
    • PR: fix(ui): improve approval guidance list layout and adding #4313
    • Head: ca17893ba449e749e5e9b6415111d970f25b6ee4
    • Result: number markers align by first text baseline in both guidance sections. 28 focused tests, root TypeScript, touched lint/format, policy/release checks and production build pass. Fresh Spec and Standards reviews have no findings. Real isolated Web UI verified in both maintained languages and themes; screenshot comparisons are embedded with explicit source provenance.
    • State: CI pending, merge remains parent-owned under the Human’s existing authorization. This Web-only follow-up does not complete the unrelated QA QA: native Always allow approval and notification acceptance #2742 performance/native gaps.
    • Cleanup: own Host/browser/children stopped and port released; Profile/evidence retained.
  16. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim — grouped editor UX follow-up

    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c
    • Branch: t3/bot-auto-approval-design
    • Scope: Human feedback on fix(ui): improve approval guidance list layout and adding #4313: increase section title/content spacing, distinguish list surfaces from the dialog, add a top-right action while retaining bottom add, focus/reveal the newly added row. Preserve explicit save and existing policy semantics.
    • State: active
  17. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work update — grouped editor feedback

    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c
    • PR: fix(ui): improve approval guidance list layout and adding #4313
    • Head: 46ceab7174ad1ce754cfbede3ebbd4f51d15e1b1
    • Revised to match Human feedback: spaced section headings, distinct light/dark list surfaces, top-right and bottom Add, appended input automatically focused and revealed.
    • 30 focused tests, types, applicable lint/format/guards and final build pass; fresh independent Spec/Standards reviews clear. Exact-head isolated Web UI, 20-row focus/reveal/no-autosave and canonical fixture restoration passed. R2 before/after embeds verified in GitHub. CodeRabbit OSS quota exhausted; neutral is not counted as passed review.
    • State: CI pending. Owned browser/Host/children stopped; port released; evidence/Profile preserved. Existing QA QA: native Always allow approval and notification acceptance #2742 gaps stay pending.
  18. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work claim — late review assertion accuracy

  19. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work update — late review test assertions

    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c
    • PR: fix(ui): improve approval guidance list layout and adding #4313
    • Head: 8925234e1cd05e61290259d7a694dde09dda89a5
    • Test-only follow-up: participant private-input masking assertion and dialog-scoped deletion recovery, canonical absence and single write. 89 focused tests, root TypeScript, touched lint/format and direct lint-staged task pass. The Husky wrapper command-resolution failure is retained; the identical hook task ran directly. Production sources and exact46 UI evidence unchanged.
    • State: replacement CI pending; existing QA QA: native Always allow approval and notification acceptance #2742 gaps remain.
  20. DoodleBears commented on Nov 16, 2026

    @DoodleBears
    ContributorAuthor

    Agent work outcome — follow-up merged

    • Agent: Codex
    • Task: codex/local/01a1df05-43d2-7380-84a0-99084cd0f49c
    • State: completed for this follow-up.
    • PR: fix(ui): improve approval guidance list layout and adding #4313
    • Head: 8f222e57d87c6d6f9b9fd7cf6fea51d61ca19d3d; merge: ca4c08ff5f7f7a5401793e2b1f7119cfa9709b2b into main.
    • Completed the Web editor feedback: aligned number/text baselines, roomier section headings, distinct themed list surfaces, top-right and bottom Add with focus/reveal, plus dialog-scoped canonical deletion recovery assertions.
    • All 9 executed final-head CI checks passed, including three affected shards, E2E and timeline budgets; 6 optional/unaffected checks skipped. Latest CodeRabbit is neutral; its earlier test nit was fixed, and no fresh final-head automated review pass is claimed. Independent UI Spec/Standards reviews remain scoped to the qualified UI source. Local final targeted expiry/types/lint/format and earlier 89-test coverage pass. Five R2 images rendered in the final PR body, explicitly qualified to production source 46ceab7.
    • No new production source after UI qualification; no new native, iOS or matched-performance acceptance. Existing QA QA: native Always allow approval and notification acceptance #2742 gaps remain.
    • Owned task processes stopped, no runtime/device retained.
  21. removed
    agent:activeOne or more coding-agent tasks currently claim this issue; see claim comments for task IDs
    on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:fullstackEnd-to-end Host and Client implementationarea:ui-uxInteraction and visual experience; may accompany a code-layer areafeature:workspaceWorkspace Grant and working-directory authorityready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions