Repository navigation
feat(team): desktop member sign-in and shared host-client packages (#4201 H1/H2) - #4265
DoodleBears wants to merge 6 commits into
Conversation
Issue: #4201 Agent-Task: codex/local/01a1e112-8bdc-7472-b4a5-e7a2c592ecb7 Co-Authored-By: Codex <noreply@openai.com>
Issue: #4201 Agent-Task: codex/local/01a1e112-8bdc-7472-b4a5-e7a2c592ecb7 Co-Authored-By: Codex <noreply@openai.com>
Pasting a Team invitation in Add Host, or choosing Sign in with a username, opens a stepper: compare the Host fingerprint, sign in with the one-time password, replace it, confirm an account switch when one is needed, then add the Host. Refusals are shown in plain words, and closing an unfinished sign-in cancels it. Issue: #4201 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue: #4201 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Add Host dialog pairs through the reciprocal relationship path, which rejected Team invitations as invalid pairing links. It now recognises a Team invitation first and opens the stepper, or explains why the invitation cannot be used. The stepper names the Host and username and drops the duplicate Cancel when embedded in settings. Issue: #4201 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The package extraction commit re-added four generated pages that main stopped tracking. Issue: #4201 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 792 files, which is 642 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
|
|
@coderabbitai review |
Action not completed
|
Refs #4201 (items 2 H1 and 3 H2). Stacked on #4165 (M8): review after it; base is
claude/4146-mobile-sign-in.Issue #4201 | M8 #4165 | Hub #4138 | Contract
Summary
Desktop can now sign in to someone else's Team mode Host as a member, and the code that desktop and mobile share no longer lives under
apps/mobile.Evidence
Two real isolated Hosts on
a2541122d: A is the desktop Owner, B is a Team mode Host with memberaliceand an invitation fromdeepseekbot members invite alice:pairReciprocalHost, which rejected Team invitations as "This isn't a pairing link". Fixed in87298f599; the dialog now recognises the invitation first.team-sign-in-dialog.test.ts: full stepper (fingerprint → wrong password refusal → sign-in → mismatch → password change → account switch → saved Host), cancel on close, plain-words start refusal, invitation detection. It also caught that the switch confirmation unmounted the flow and cancelled it; fixed.--maxWorkers=2): 15,750 passed, 74 skipped. The 9 failures in that run were checked: 4 generated docs pages had been re-committed by the package extraction (untracked again ina2541122d);dev-isolated-imports*pass with a canonicalTMPDIR(macOS symlinked temp dir, unchanged guards); the changelog test timed out under load and passes alone.pnpm e2e:smokepass.Merge Danger
Door: two-way
No migration. Large file moves between workspace packages; the computer-side bundles inline both private workspaces, and published plugin manifests keep them as build-time dependencies.
Blast Radius: broad
Every desktop remote-Host and mobile Host session import path moves to the shared packages; the Add Host dialog gains a Team branch.
🤖 Generated with Claude Code