Use Gunicorn for container server - #7
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Gunicorn’s default bind port logic can diverge from the application’s production port defaults when APP_ENV=production and APP_PORT is unset, risking misconfigured container routing.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Gunicorn as the container’s runtime server configuration so the app runs under a production-grade WSGI process manager instead of python app.py.
Changes:
- Introduces
gunicorn.conf.pywith worker/threading, logging, recycling, and optional TLS configuration driven by environment variables. - Updates
Dockerfileto copy the Gunicorn config and start the container withgunicorn ... app:server.
File summaries
| File | Description |
|---|---|
| gunicorn.conf.py | New Gunicorn configuration for container runtime (bind/workers/logging/TLS). |
| Dockerfile | Switch container startup from python app.py to gunicorn using the new config. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| import os | ||
|
|
||
|
|
||
| bind = f"{os.getenv('APP_HOST', '0.0.0.0')}:{os.getenv('APP_PORT', '5000')}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.