[BI-2902] Germplasm Cache - Remove programGermplasmCache.get() usages - #550
Open
jloux-brapi wants to merge 7 commits into
Open
[BI-2902] Germplasm Cache - Remove programGermplasmCache.get() usages#550jloux-brapi wants to merge 7 commits into
jloux-brapi wants to merge 7 commits into
Conversation
humsika
reviewed
Aug 31, 2026
Collaborator
Author
|
The germplasm changes here clash with the brapi-prod-server:develop tag used for the unit tests, so the maven build will always fail. The actual build to look at is here, which targets the latest Eventually I will merge these changes into the target branch without a check so it can get in. I will refrain from making the merge until the study cache work is complete. |
Contributor
|
Got it, thanks for clarifying. Holding the merge until the study cache work is done makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2902
Removal of all
programGermplasmCache.get()calls and associated usages and unit test failures.Dependencies
epic/BI-2862branches ofbi-web,brapi-java-prodserverTesting
No real testing, as certain aspects of germplasm will be broken without frontend and external ref swapping. Code review only.
wrt unit tests: there is a failure related to a new ticket that has been created: BI-3034.
Checklist: