Skip to content

Changes to support removal of Germplasm cache - #494

Open
jloux-brapi wants to merge 1 commit into
epic/BI-2862from
feature/BI-2905
Open

Changes to support removal of Germplasm cache#494
jloux-brapi wants to merge 1 commit into
epic/BI-2862from
feature/BI-2905

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Story: BI-2905

Changes to use brapi germplasmDbId instead of bi generated exref

Dependencies

epic/BI-2862 branch of brapi prod server
feature/BI-2904 of biapi

Testing

Full regression for most germplasm features, excluding sample importing, which will be dealt with once develop bi-api code is merged and this ticket

This features include:

  • Importing Germplasm with various use cases, including parent lookups via existing germplasm lookups or via-entry numbers
  • Downloading imported germplasm
  • Viewing imported germplasm in the Germplasm tab, and clicking all associated links in the rows including the GID, both parent links, and Show Details
  • Clicking on existing Germplasm brings up the Pedigree Viewer, where you can click on other germplasm in the hierarchy tree. These should load without error. NOTE: A production bug was discovered clicking back in these scenarios, these changes did not cause this issue)

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth
  • I have run SiteImprove on pages impacted by changes

@humsika humsika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and also validated it manually through UI.

@humsika humsika added the on hold Don't merge until this label is removed label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature on hold Don't merge until this label is removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants