Pause and resume both live in control/1.0 (#157) - #170
Merged
Merged
Conversation
#142 removed paused -> in_progress from task.update, so control.resume became the only way out of a pause, but created -> paused and in_progress -> paused stayed in the map. Pause was reachable from Core while resume required control/1.0. Today that is recoverable, because control.resume executes whatever the workspace advertises. Under the dispatch gate in #136 it would not be: a workspace advertising core/1.0 and review/1.0 alone would have control.resume refused, and any member could strand any task with a pause the workspace had no advertised method to lift. Both references drop paused from the task.update target sets, and SPECIFICATION 8.1 moves with them. paused -> cancelled through task.update is unchanged, so a stranded task from an older store can still be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#142 removed paused -> in_progress from task.update, so control.resume became the only way out of a pause, but created -> paused and in_progress -> paused stayed in the map. Pause was reachable from Core while resume required control/1.0.
Today that is recoverable, because control.resume executes whatever the workspace advertises. Under the dispatch gate in #136 it would not be: a workspace advertising core/1.0 and review/1.0 alone would have control.resume refused, and any member could strand any task with a pause the workspace had no advertised method to lift.
Both references drop paused from the task.update target sets, and SPECIFICATION 8.1 moves with them. paused -> cancelled through task.update is unchanged, so a stranded task from an older store can still be closed.