Skip to content

GAUD-10606: Adds overflow-wrap: anywhere to wrap large words/texts and avoid overflowing #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwinACL831 merged 3 commits into from
Sep 17, 2026
Merged

GAUD-10606: Adds overflow-wrap: anywhere to wrap large words/texts and avoid overflowing #7498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0956d9a
Adds overflow-wrap: anywhere to wrap large words/texts and avoid over…
Sep 17, 2026
5b9ad64
Adds vdiffs tests for radial and circle meters.
Sep 17, 2026
152a5a5
Updating vdiff goldens (#7499)
github-actions[bot] Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/meter/meter-styles.js
View file
Open in desktop

@EdwinACL831 EdwinACL831 Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could potentially impact also vdiffs
New vdiffs were actually added

Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import '../colors/colors.js';
import { css } from 'lit';
import { css, unsafeCSS } from 'lit';
import { getFlag } from '../../helpers/flags.js';

const overflowWrapValue = unsafeCSS(getFlag('GAUD-10606-overflow-wrap-anywhere', true) ? 'anywhere' : 'normal');

export const meterStyles = css`
.d2l-meter-container {
Expand Down Expand Up @@ -28,6 +31,7 @@ export const meterStyles = css`
color: var(--d2l-color-ferrite);
fill: var(--d2l-color-ferrite);
line-height: 0.8rem;
overflow-wrap: ${overflowWrapValue};
text-align: center;
}
:host([foreground-light]) .d2l-meter-text {
Expand Down
Binary file added components/meter/test/golden/meter-circle/chromium/text-long-word.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added components/meter/test/golden/meter-radial/chromium/text-long-word-rtl.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added components/meter/test/golden/meter-radial/chromium/text-long-word.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions components/meter/test/meter-circle.vdiff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('meter-circle', () => {
{ name: '100-percent', template: html`<d2l-meter-circle value="10" max="10" percent></d2l-meter-circle>` },
{ name: 'text', template: html`<d2l-meter-circle value="10" max="10" text="Done!"></d2l-meter-circle>` },
{ name: 'text-text-hidden', template: html`<d2l-meter-circle value="10" max="10" text="Completed" text-hidden></d2l-meter-circle>` },
{ name: 'text-long-word', template: html`<d2l-meter-circle value="10" max="10" text="Pneumonoultramicroscopicsilicovolcanoconiosis"></d2l-meter-circle>` },
{ name: 'foreground-light', wrapped: true, template: html`
<div style="background-color: var(--d2l-color-celestine); padding: 1rem;">
<d2l-meter-circle value="16" max="47" foreground-light></d2l-meter-circle>
Expand Down
1 change: 1 addition & 0 deletions components/meter/test/meter-radial.vdiff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ describe('meter-radial', () => {
{ name: 'progress', template: html`<d2l-meter-radial value="16" max="47"></d2l-meter-radial>` },
{ name: 'percent', template: html`<d2l-meter-radial value="16" max="47" percent></d2l-meter-radial>` },
{ name: 'text', template: html`<d2l-meter-radial value="10" max="10" percent text="Completed"></d2l-meter-radial>` },
{ name: 'text-long-word', template: html`<d2l-meter-radial value="10" max="10" percent text="Pneumonoultramicroscopicsilicovolcanoconiosis"></d2l-meter-radial>` },
].forEach(({ name, template }) => {
it(`${name}${ rtl ? '-rtl' : ''}`, async() => {
const elem = await fixture(template, { rtl });
Expand Down