Skip to content

GAUD-10607: update to Mocha 12 - #1077

Merged
dlockhart merged 2 commits into
mainfrom
GAUD-10607/mocha-12
Sep 8, 2026
Merged

GAUD-10607: update to Mocha 12#1077
dlockhart merged 2 commits into
mainfrom
GAUD-10607/mocha-12

Conversation

@dlockhart

@dlockhart dlockhart commented Sep 3, 2026

Copy link
Copy Markdown
Member

No description provided.

Comment thread package.json
"eslint-config-brightspace": "^4",
"globals": "^17",
"mocha": "^11",
"mocha": "^12",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little surprised that this was just a devDependency, but because we rely on @open-wc/testing and @web/test-runner to run the tests, it seems OK? They actually don't have a dependency on Mocha either, which is a bit strange.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm a little concerned about our usage in the vdiff runner, but we can investigate that separately if it becomes an issue.

Comment thread package-lock.json
Comment thread package.json
"@web/test-runner-playwright": "^1",
"command-line-args": "^6",
"command-line-usage": "^7",
"d2l-test-reporting": "^6",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a direct dependency on mocha, so we'll want to wait for it to update & release before releasing this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dlockhart
dlockhart marked this pull request as ready for review September 8, 2026 13:39
@dlockhart
dlockhart requested a review from a team as a code owner September 8, 2026 13:39
Comment thread package.json
"eslint-config-brightspace": "^4",
"globals": "^17",
"mocha": "^11",
"mocha": "^12",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm a little concerned about our usage in the vdiff runner, but we can investigate that separately if it becomes an issue.

@dlockhart
dlockhart merged commit 276ab9a into main Sep 8, 2026
7 checks passed
@dlockhart
dlockhart deleted the GAUD-10607/mocha-12 branch September 8, 2026 13:50
@d2l-github-release-tokens

Copy link
Copy Markdown

🎉 This PR is included in version 1.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants