Skip to content

Auto command caller - #534

Merged
mquinson merged 2 commits into
BuggleInc:javaUIfrom
Wyrdix:auto_command_caller
Jul 1, 2026
Merged

mquinson merged 2 commits into
BuggleInc:javaUIfrom
Wyrdix:auto_command_caller

Conversation

@Wyrdix

@Wyrdix Wyrdix commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Add CommandExecutor responsible for the parsing and execution of command from entity execution.

@mquinson

mquinson commented Jul 1, 2026

Copy link
Copy Markdown
Member

Hello,

thanks for that. Could you tell me quickly why we need a separate executor ? What was the pb with having the entity parsing and executing directly the command?

I just want to ensure that we don't replace the existing overly complex design with a new overly complex design (even if the new one would be more in phase with the current Java design habits, with generators etc) :-P

Thanks, Mt

@Wyrdix

Wyrdix commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

The main goal is to replace parsing and opcode matching by hand in entities classes. The logic is always the same and is prone to error as opcodes need to be duplicated at multiple places currently (in the c language bindings and in the java code). The full system now use a single point of truth (the primitive annotation), previous prs added the ability to generate bindings from those annotations. This one add the ability to dispatch command using this annotation.

I chose to separate the logic it its own as this function is general and is independent of the entity

@mquinson
mquinson merged commit 1b93a8b into BuggleInc:javaUI Jul 1, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants