Repository navigation
Auto command caller - #534
Conversation
…on of an object instead of its serialized version
|
Hello, thanks for that. Could you tell me quickly why we need a separate executor ? What was the pb with having the entity parsing and executing directly the command? I just want to ensure that we don't replace the existing overly complex design with a new overly complex design (even if the new one would be more in phase with the current Java design habits, with generators etc) :-P Thanks, Mt |
|
The main goal is to replace parsing and opcode matching by hand in entities classes. The logic is always the same and is prone to error as opcodes need to be duplicated at multiple places currently (in the c language bindings and in the java code). The full system now use a single point of truth (the primitive annotation), previous prs added the ability to generate bindings from those annotations. This one add the ability to dispatch command using this annotation. I chose to separate the logic it its own as this function is general and is independent of the entity |
Add CommandExecutor responsible for the parsing and execution of command from entity execution.