Skip to content

docs: add dark mode logo support with theme-aware SVG assets - #77

Merged
bogdan-at-bunny merged 1 commit into
mainfrom
chore/readme
Oct 21, 2026
Merged

bogdan-at-bunny merged 1 commit into
mainfrom
chore/readme

Conversation

@TenGosc007

Copy link
Copy Markdown
Collaborator

Summary

The "bunny" wordmark in resources/bunnynet.svg has no explicit fill, so it rendered black and nearly disappeared on GitHub's dark mode. The README header now wraps the logo in a <picture> element with a prefers-color-scheme: dark source pointing to the new white-wordmark asset (docs/img/Horizontal-full-color-white.svg) supplied by product marketing. Light mode and non-supporting renderers continue to use the existing logo. Both SVGs share the same aspect ratio, so the width="70%" sizing applies identically.

Type of Change

  • Bug fix
  • Feature
  • Documentation
  • Refactor or cleanup
  • CI/build/release
  • Breaking change

Affected Areas

  • TurboModule / native modules
  • API client
  • Upload
  • Player (VOD)
  • Player (live)
  • Broadcaster
  • Codegen / spec files
  • Example app
  • Documentation
  • Build or package configuration

Testing

Docs-only change — verified the <picture> markup, the prefers-color-scheme: dark media query (the GitHub-supported dark-mode mechanism), and that both SVGs share an equivalent aspect ratio so sizing stays consistent.

  • yarn typecheck
  • yarn lint
  • yarn test
  • Android example builds (yarn android in example/)
  • iOS example builds (yarn ios in example/)
  • Manual playback/upload/broadcast test
  • Not run, reason: README asset/markup change only; no code affected.

Library User Impact

None — README rendering only. The new asset lives in docs/img/ and is not shipped in the npm package.

AI Assistance

  • No substantial AI assistance was used.
  • AI helped with this PR; I reviewed and understand the final changes.

Checklist

  • The PR is focused on one clear change.
  • native-sdk-baselines.json points to a public, merged native SDK commit or tag when native APIs are required.
  • Public API or behavior changes are documented (README / docs).
  • Tests or manual verification are included where appropriate.
  • No secrets, access keys, private URLs, certificates, or provisioning profiles are included.

@TenGosc007 TenGosc007 self-assigned this Oct 21, 2026
@TenGosc007
TenGosc007 marked this pull request as ready for review October 21, 2026 12:49
@bogdan-at-bunny
bogdan-at-bunny merged commit 602da69 into main Oct 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants