Repository navigation
experiment(apps): dockerfile gen - #261
jamie-at-bunny wants to merge 12 commits into
Conversation
…and single-file apps
|
@codex review |
🦋 Changeset detectedLatest commit: f2ce76e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca9ea3055c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { existsSync, readFileSync } from "node:fs"; | ||
| import { existsSync, readFileSync, writeFileSync } from "node:fs"; | ||
| import { basename, dirname, isAbsolute, relative, resolve } from "node:path"; | ||
| import { detectFramework } from "@/commands/sites/ci/frameworks.ts"; |
There was a problem hiding this comment.
The Apps walkthrough now imports an implementation module from the Sites command tree, coupling two command domains and making changes to Sites internals affect Apps. Move the shared filesystem-backed framework detector into core/ or the framework-detector package and have both domains import it from there.
AGENTS.md reference: AGENTS.md:L85-L85
Useful? React with 👍 / 👎.
…-allow-split-volumes
2 participants
No description provided.