Repository navigation
fix: select the Unix trash backend explicitly - #429
Merged
Merged
Conversation
<!-- agent --> Installing `dua-cli` with an unlocked dependency graph selects trash 5.3.0, which now requires either freedesktop or portal on supported Unix targets. dua disables dependency defaults, so the platform module was missing. The existing lockfile pinned 5.2.5 and hid the failure from CI. Require trash 5.3.0 and enable freedesktop only for its supported Unix targets, retaining the native macOS and Windows backends and the optional trash-move feature. Refresh the lockfile so CI builds the affected version. Assisted-by: GPT 6.1 Sol Co-authored-by: GPT 6.1 Sol <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by
GPT-6.Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Fixes #428.
Source installation resolves trash 5.3.0, which requires a Unix backend feature. dua disables trash's defaults, so Linux compilation fails with a missing
platformmodule. The lockfile's older trash 5.2.5 masked the failure in CI.Enable
freedesktopthrough a target-specific dependency for the Unix platforms supported by that backend. macOS and Windows retain their native backends, and disablingtrash-movestill omits trash entirely. Require trash 5.3.0 because earlier releases do not expose the new feature, and refresh the lockfile.Add a CI check of Cargo's resolved backend features for Linux, FreeBSD, macOS, and Windows. The check failed before the fix; a Linux cross-check also reproduced the three compiler errors reported in the issue.
Validation passed:
sh ci/check-trash-features.shcargo check --lockedwith defaults, no defaults, andtrash-moveonlymake check-pre-push(feature combinations, tests, journey tests, formatting, and Clippy)A new dua-cli release will be needed to repair source installation of the already-published 3.0.0.