Skip to content

feat: queue deletion until the scan finishes - #434

Merged
Byron merged 1 commit into
mainfrom
queue-deletion
Nov 16, 2026
Merged

Byron merged 1 commit into
mainfrom
queue-deletion

Conversation

@Byron

@Byron Byron commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Tried it locally

A confirmed deletion should be usable during scanning without removing
entries while traversal results are still being integrated. Queue the
requested Delete or Trash action and start the existing deletion worker
automatically after the scan and any snapshot export have completed.

Freeze the marked selection while it waits, show the queued status in the
footer and mark pane, and cancel the request on exit or an event-loop
failure. This keeps traversal integration and deletion accounting unchanged.

Validation: all 156 binary tests pass with and without Trash support,
including automatic execution, frozen marks, and queued cancellation.
Formatting passes. Clippy passes with the existing inodefilter.rs
needless_bool warning suppressed.

Tried it locally, code is rubber-stamp. It's simple enough, which is what matters.

<!-- agent -->
A confirmed deletion should be usable during scanning without removing
entries while traversal results are still being integrated. Queue the
requested Delete or Trash action and start the existing deletion worker
automatically after the scan and any snapshot export have completed.

Freeze the marked selection while it waits, show the queued status in the
footer and mark pane, and cancel the request on exit or an event-loop
failure. This keeps traversal integration and deletion accounting unchanged.

Validation: all 156 binary tests pass with and without Trash support,
including automatic execution, frozen marks, and queued cancellation.
Formatting passes. Clippy passes with the existing inodefilter.rs
needless_bool warning suppressed.

Assisted-by: GPT 6.1 Sol
Co-authored-by: GPT 6.1 Sol <codex@openai.com>
@Byron

Byron commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Supersedes #433

@Byron
Byron merged commit 0435627 into main Nov 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant