Repository navigation
feat: queue deletion until the scan finishes - #434
Merged
Merged
Conversation
Tried it locally, code is rubber-stamp. It's simple enough, which is what matters. <!-- agent --> A confirmed deletion should be usable during scanning without removing entries while traversal results are still being integrated. Queue the requested Delete or Trash action and start the existing deletion worker automatically after the scan and any snapshot export have completed. Freeze the marked selection while it waits, show the queued status in the footer and mark pane, and cancel the request on exit or an event-loop failure. This keeps traversal integration and deletion accounting unchanged. Validation: all 156 binary tests pass with and without Trash support, including automatic execution, frozen marks, and queued cancellation. Formatting passes. Clippy passes with the existing inodefilter.rs needless_bool warning suppressed. Assisted-by: GPT 6.1 Sol Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Byron
force-pushed
the
queue-deletion
branch
from
November 16, 2026 11:37
f7ff712 to
534bf82
Compare
Owner
Author
|
Supersedes #433 |
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried it locally
A confirmed deletion should be usable during scanning without removing
entries while traversal results are still being integrated. Queue the
requested Delete or Trash action and start the existing deletion worker
automatically after the scan and any snapshot export have completed.
Freeze the marked selection while it waits, show the queued status in the
footer and mark pane, and cancel the request on exit or an event-loop
failure. This keeps traversal integration and deletion accounting unchanged.
Validation: all 156 binary tests pass with and without Trash support,
including automatic execution, frozen marks, and queued cancellation.
Formatting passes. Clippy passes with the existing inodefilter.rs
needless_bool warning suppressed.