Repository navigation
[FIX] Honor 23.976 fps when importing SCC - #2452
Open
harshalsp07 wants to merge 1 commit into
Open
harshalsp07 wants to merge 1 commit into
harshalsp07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
--scc-framerate 23.976and its23.98alias are accepted by the CLI, but SCC import silently uses 29.97 fps. Both spellings become integer value 4;SccFrameRate::from_int()doesn't handle it and falls back to the default.Add the missing decoder rate and use
1001 / 24milliseconds per frame. The other rate mappings stay the same.Reproduce from the repository root with the included 90-byte sample:
The sample contains
HIbetween00:00:01:12and00:00:03:12. On masterd7eb132e, the SRT timing is00:00:01,401 --> 00:00:03,399. With this change it is00:00:01,501 --> 00:00:03,499. Repeating with23.98gives the same corrected timing.Tested on Linux:
cargo test --lockedinsrc/rust: 427 passed. The new SCC parsing test fails without the fix.cargo fmt --all -- --checkandcargo clippy -- -D warningspass.This fixes SCC input parsing. #2145 and #2406 concern CEA-708 SCC output timing. Windows/macOS and the external sample platform haven't been tested.
CI note: The initial Linux build stops before compilation because
libgpac-devhas no installation candidate on Ubuntu 26.04; #2428 addresses the runner change. The C format check also flagsccx_decoders_isdb.candmp4.c, which are unchanged from master.