Skip to content

Fix #2450: Support --utf8 and --latin1 encoding for CEA-708 output - #2454

Open
yasar710 wants to merge 1 commit into
CCExtractor:masterfrom
yasar710:patch-3
Open

yasar710 wants to merge 1 commit into
CCExtractor:masterfrom
yasar710:patch-3

Conversation

@yasar710

@yasar710 yasar710 commented Nov 6, 2026

Copy link
Copy Markdown

Updates dtvcc_write_row to respect --utf8 and --latin1 command-line flags instead of defaulting to raw bytes. This resolves the encoding issue for CEA-708 subtitles reported in #2450.

In raising this pull request, I confirm the following (please check boxes):

Reason for this PR:

  • This PR adds new functionality.
  • This PR fixes a bug that I have personally experienced or that a real user has reported and for which a sample exists.
  • This PR is porting code from C to Rust.

Sanity check:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • If the PR adds new functionality, I've added it to the changelog. If it's just a bug fix, I have NOT added it to the changelog.
  • I am NOT adding new C code unless it's to fix an existing, reproducible bug.

Repro instructions:

This is essential. We will not merge ANY PR that doesn't come with detailed instructions, including a sample. We don't want
"fixes" for theoretical issues that an AI agent found, without context. If you can't reproduce the bug, don't send a PR.

Creating PRs with AI is very quick, but we still have humans (even if AI assisted) going over each.

Be mindful of reviewers' time.


{pull request content here}

…8 output

Updates dtvcc_write_row to respect --utf8 and --latin1 command-line flags instead of defaulting to raw bytes. This resolves the encoding issue for CEA-708 subtitles reported in CCExtractor#2450.
@yasar710

yasar710 commented Nov 6, 2026

Copy link
Copy Markdown
Author

Hi, the CI checks are failing during the "Install dependencies" step with the error: "E: Package 'libgpac-dev' has no installation candidate". This seems to be a GitHub Actions environment issue and not related to the C code changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant