Repository navigation
Conversation
…8 output Updates dtvcc_write_row to respect --utf8 and --latin1 command-line flags instead of defaulting to raw bytes. This resolves the encoding issue for CEA-708 subtitles reported in CCExtractor#2450.
Author
|
Hi, the CI checks are failing during the "Install dependencies" step with the error: "E: Package 'libgpac-dev' has no installation candidate". This seems to be a GitHub Actions environment issue and not related to the C code changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dtvcc_write_row to respect --utf8 and --latin1 command-line flags instead of defaulting to raw bytes. This resolves the encoding issue for CEA-708 subtitles reported in #2450.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
This is essential. We will not merge ANY PR that doesn't come with detailed instructions, including a sample. We don't want
"fixes" for theoretical issues that an AI agent found, without context. If you can't reproduce the bug, don't send a PR.
Creating PRs with AI is very quick, but we still have humans (even if AI assisted) going over each.
Be mindful of reviewers' time.
{pull request content here}