Skip to content

Fixes possible incorrect mapping between eai metric values and exposure points in trajectories #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spjuhel wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixes possible incorrect mapping between eai metric values and exposure points in trajectories #1297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986afaa
Fixes a bug in eai metric
spjuhel Jun 16, 2026
0da3b6e
Merge branch 'develop' into fix-trajectory_eai_metric
emanuel-schmid Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions climada/trajectories/calc_risk_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,12 @@ def calc_eai_gdf(self) -> pd.DataFrame:

"""

metric_df = pd.DataFrame(self.per_date_eai, index=self._date_idx)
metric_df = pd.DataFrame(
self.per_date_eai,
index=self._date_idx,
columns=self.snapshots[0].exposure.gdf.index,
Comment on lines +260 to +261

@emanuel-schmid emanuel-schmid Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh, i don't quite understand the idea behind having both, self._date_idx and self.date_idx, especially in the combination with the @data_idx.setter - nevertheless: why not index=self.date_idx?,

@emanuel-schmid emanuel-schmid Sep 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only relevant difference to the develop branch seems to be the explicit setting of columns. however, there is no hint to the rationale in the PR description.

)

metric_df = metric_df.reset_index().melt(
id_vars=DATE_COL_NAME, var_name=COORD_ID_COL_NAME, value_name=RISK_COL_NAME
)
Expand Down Expand Up @@ -868,7 +873,11 @@ def calc_eai_gdf(self) -> pd.DataFrame:
(notably for `value` and `group_id`).

"""
metric_df = pd.DataFrame(self.per_date_eai, index=self.date_idx)
metric_df = pd.DataFrame(
self.per_date_eai,
index=self._date_idx,
columns=self.snapshot_start.exposure.gdf.index,
)
metric_df = metric_df.reset_index().melt(
id_vars=DEFAULT_PERIOD_INDEX_NAME,
var_name=COORD_ID_COL_NAME,
Expand Down
Loading