-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/qa #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix/qa #107
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcm.required: true가application-aws.yml뿐 아니라 이 baseapplication.yml에도 그대로 들어가 있습니다.application.yml은 프로파일과 무관하게 항상 로드되는 base 설정이므로,FCMConfig.java의 주석("운영(aws 프로파일)에서만 true. 키가 없으면 기동을 깨서 배포 시점에 드러낸다")과 기본값(@Value("${fcm.required:false}"))의 의도와 달리 로컬 개발/CI 환경에서도 fail-fast가 적용됩니다.이 저장소에는
serviceAccountKey.json파일이 존재하지 않고(.gitignore에 등록됨),FCM_SERVICE_ACCOUNT_B64환경변수도 로컬에는 보통 없으므로,openCredentials()가null을 반환 →required == true→IllegalStateException으로@PostConstruct가 실패해 애플리케이션 컨텍스트 로딩 자체가 깨집니다. 이 PR이 새로 추가한 "키 없으면 경고 로그만 남기고 계속 부팅" 폴백 경로(log.warn("FCM 키 없음 - 푸시 비활성화 상태로 기동"))가 모든 프로파일에서 도달 불가능한 죽은 코드가 되는 셈입니다.이 저장소는 fail-fast류 설정(예:
spring.kafka.admin.fail-fast: true)을 prod(application-aws.yml) 전용으로만 두는 관례가 이미 있는데, 이번 변경은 그 관례와도 어긋납니다.application.yml(base)의required는false로 두고,true는application-aws.yml쪽에만 남겨야 합니다.