Repository navigation
fix: add GHCR login to disk build job - #47
Merged
Merged
Conversation
The build job pulls versioned container images from GHCR but never authenticates, causing 'unauthorized' failures when the package registry requires login. Add a GHCR login step after checkout so podman can pull the private images. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disk build job pulls versioned container images from GHCR (e.g. `ghcr.io/cstaks/calos:v1.1.5`) but never authenticates before the pull, causing `unauthorized` failures on private packages.
Adds a `docker/login-action` step after checkout and before the podman storage reset, matching the login step already present in the `build-versioned-images` job.
Root cause: The `build-versioned-images` job logs in to push images, but the downstream `build` job (which pulls them for disk image creation) had no login step.
Fix: `docker/login-action@v4.5.1` with `GITHUB_TOKEN` in the `build` job, placed after checkout and before the podman storage reset.
🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com